Commit Graph

16125 Commits

Author SHA1 Message Date
elexis bc40ebb97e Improve bartering GUI responsiveness and immediately switch to the selected resource instead of waiting one turn. Refs #3194.
This was SVN commit r18416.
2016-06-21 09:34:26 +00:00
elexis 4fde34c168 Revert be5f2d2bb5 since the implicit conversion throws a warning.
This was SVN commit r18415.
2016-06-21 00:06:14 +00:00
mimo 600f21578f cleanup of some replay and savedgame stuff
This was SVN commit r18414.
2016-06-20 17:43:16 +00:00
elexis be5f2d2bb5 Remove an unneeded String() conversion.
This was SVN commit r18413.
2016-06-20 16:09:57 +00:00
elexis 23a9fa1e65 Trigger script cleanup.
Remove tons of trailing whitespace.
Format JSdoc comments properly.
Use alphabetical sorting in array.
let instead of var.
Eliminate deprecated for-each.

This was SVN commit r18412.
2016-06-20 15:59:14 +00:00
elexis 86db6dcf12 Implement wonder victory games that are finished instantaneously after build, refs #3234.
Thus don't supplement the hypothetically missing wonderduration
gameattribute with a hardcoded simulation default.

This was SVN commit r18411.
2016-06-20 15:46:21 +00:00
mimo f7ff2f2e99 improve load game UI, fixes #1090
This was SVN commit r18409.
2016-06-19 21:01:25 +00:00
niektb 5bc0de7f3a Put the newly credited persons in 24b2a2b828 in an alphabetical order
This was SVN commit r18408.
2016-06-19 18:13:35 +00:00
niektb 24b2a2b828 Three new fauna portraits made by Foaly
This was SVN commit r18407.
2016-06-19 18:08:39 +00:00
elexis 5186560466 Suppress a warning.
This was SVN commit r18406.
2016-06-19 14:37:38 +00:00
elexis 22f6daf612 Add missing territory to corrals (to prevent decay in connected allied territory).
Increase territory of the storehouse slightly to allow adjacent
buildings.

This was SVN commit r18405.
2016-06-19 14:32:42 +00:00
mimo dbe985cd78 petra: remove some useless return
This was SVN commit r18404.
2016-06-18 17:34:02 +00:00
mimo e8291130bd petra: update list of enemy structures when diplomacy changes
This was SVN commit r18403.
2016-06-18 16:59:34 +00:00
elexis 932b0c1e3e Trireme and bireme ship balancing.
The mauryan empire is not known to have the strongest fleet, so reduce
their ships hitpoints to the average for that model.
Redue bireme metal cost to make it an actual alternative to the trireme,
considering population cost and hitpoints.
Remove a hardoded linenumber in a comment.

This was SVN commit r18402.
2016-06-18 14:30:21 +00:00
elexis 64d14b9fc6 Fix "supersedes" indentation issue of technologies in 4c22d4631a.
This was SVN commit r18401.
2016-06-18 11:07:44 +00:00
elexis b28dfb42df Fix indentation of auras in 46ead523b8. Patch by fatherbushido, reported by leper, fixes #4062, refs #3792.
This was SVN commit r18400.
2016-06-18 10:45:33 +00:00
elexis 09fdf716e9 Session cleanup.
Move chat window and developer overlay to a custom file.
Use String(foo) instead of ""+foo.
Remove a pointless loop and GetGUIObjectByName call in autoCompleteNick.
Remove noisy line-comments.

This was SVN commit r18399.
2016-06-17 15:38:07 +00:00
elexis f4b818bec4 Wonder mode cleanup.
Remove unused, seemingly unusable wonder duration multiplier, refs
#3234.
Replace wonderDuration of the EndGameManager with gameTypeSettings,
since the component should be agnostic about victory condition logic.
Remove an unused cmpEndGameManager.
Inline a variable, few newlines, let intsead of var.

This was SVN commit r18398.
2016-06-17 14:24:30 +00:00
elexis 8c69309e7c Missing semicolon, rephrase comment, refs #3216.
This was SVN commit r18397.
2016-06-17 12:08:40 +00:00
elexis f60befe098 Capture statistics summary. Patch by maveric and Imarok, fixes #3216.
Also colorize the headings, use two lines per player and remove
duplication of an ugly regex hack.

This was SVN commit r18395.
2016-06-17 02:27:11 +00:00
elexis df764c0200 Increase vision range proportionally when increasing the attack range. Patch by Imarok, fixes #3989.
This was SVN commit r18394.
2016-06-17 01:11:39 +00:00
elexis a214f83017 Trader cleanup.
Remove unused required goods.
Won't be used since setting the goods individually for every trader is
overkill.

This was SVN commit r18393.
2016-06-16 20:54:31 +00:00
elexis 7c9c715ddc Tech tree cleanup.
Newlines.
Eliminate deprecated for each.
One or two simplifications.

This was SVN commit r18392.
2016-06-16 20:26:36 +00:00
elexis a874b3c1c3 Colorize playernames in the kick/ban chat notification, refs #3241.
This was SVN commit r18391.
2016-06-16 17:13:02 +00:00
sanderd17 450973a624 Clean up some code-style issues reported by leper
This was SVN commit r18390.
2016-06-16 14:51:12 +00:00
elexis ed7924f9ca Session GUI cleanup
Use arrow functions.
Inline exchangeResources which was defined in the wrong file.
Remove unused selectRequiredGoods. Related code should be removed likely
too.
Add missing translate.

This was SVN commit r18389.
2016-06-16 01:08:36 +00:00
elexis 8aea8d0849 Replace magic number with a readable string, refs #3436.
This was SVN commit r18388.
2016-06-16 00:40:21 +00:00
mimo f25921ba24 improve 2392f6fe8e as these checks are also done in Commands.js, thanks to leper
This was SVN commit r18387.
2016-06-15 21:20:04 +00:00
mimo 6da94fef96 petra cleanup, spotted by leper
This was SVN commit r18386.
2016-06-15 21:06:09 +00:00
elexis 156b360f06 Print engine version to the logfiles.
This was SVN commit r18385.
2016-06-15 19:26:28 +00:00
elexis ed225e1fc4 Chat cleanup, refs #3870.
Remove toggleChatWindow which duped openChat and closeChat.
Toggling the chat window with hotkeys is pointless due to the focus.
Inline setTeamChat.
Add some newlines, 2 missing semicolons and remove unneeded comments.

This was SVN commit r18384.
2016-06-15 16:54:16 +00:00
elexis 8302eeaf73 Rest of the previous commit.
This was SVN commit r18383.
2016-06-15 16:16:55 +00:00
elexis 0ce02441ee Simulation cleanup
Use QueryPlayerIDInterface to remove duplication as suggested by leper.
Remove its duplicate GetPlayerComponent.
Add IsOwnedByHelper and IsOwnedByEntityHelper to remove duplicated ally
check functions.
Remove unused function GetPlayerFilter from 17c473f2f3.
Remove unused variables and access to undefined ones identified using
jshint.
Rename cmpPlayerMan.

This was SVN commit r18382.
2016-06-15 16:13:08 +00:00
elexis 84d5fb2d34 Tooltip GUI engine cleanup.
Merge some if statements.
Fix whitespace.
Remove unneeded comments and braces.
Remove one duplicated statement out of an if-statement.

This was SVN commit r18381.
2016-06-15 15:40:05 +00:00
elexis 997ea01b2b Fix typo in 366085e037 as reported by mimo.
This was SVN commit r18380.
2016-06-14 21:29:37 +00:00
elexis a296909f91 GUI engine cleanup.
Merge a check.
Remove unneeded comments and braces.
Some whitespace fixes.

This was SVN commit r18379.
2016-06-14 15:06:39 +00:00
elexis a9426a3f26 Distinguish private and public room level messages in the lobby. Patch by scythetwirler, refs #3865.
This was SVN commit r18378.
2016-06-14 14:07:52 +00:00
elexis 8d9255eaee Lobby cleanup.
Remove duplicate assignments in updateGameSelection.
Add function senderFont to remove duplication.
Add newlines to reduce line length and have properties of different
objects start on the same level of indentation.
Use logical OR instead of ternary in two occurances (mapTypeIdx).

This was SVN commit r18377.
2016-06-14 13:28:54 +00:00
elexis b65594832d Lobby cleanup.
Use let instead of var.
Merge redundant assignment in updateSubject.

This was SVN commit r18376.
2016-06-14 12:34:46 +00:00
elexis fb5e738920 Lobby cleanup. Patch by scythetwirler, refs #3865.
Replace an ugly workaround of ccb534259d with a proper check.

This was SVN commit r18375.
2016-06-14 12:17:37 +00:00
elexis 949f22b67d Victory check cleanup.
Use let instead of var.
Add newlines and a missing semicolon.
Remove an excess semicolon.

This was SVN commit r18374.
2016-06-14 11:18:28 +00:00
elexis 62061557db Host on arbitrary UDP ports. Patch in cooperation with Imarok, fixes #3575.
This was SVN commit r18372.
2016-06-13 16:56:14 +00:00
elexis 7b655b7ea6 Implement multiplayer dialog retries, fixes #4035, refs #3575.
Cleanup:
Move all code to hide elements to switchSetupPage.
Remove nasty second argument from switchSetupPage by just hiding every
page.
To avoid another state variable, immediately set g_IsConnecting to true
by calling startConnectionStatus when trying to host.
Use .some instead of a loop.

This was SVN commit r18371.
2016-06-13 14:29:52 +00:00
elexis 320798f901 Don't select "everyone" but the previously selected chat addressee when someone connected or disconnected. Fixes #3956.
This was SVN commit r18369.
2016-06-12 21:11:01 +00:00
elexis 31decd6274 Messed up variable name in 9dc66a27d8.
This was SVN commit r18368.
2016-06-12 15:29:43 +00:00
sanderd17 929711febb Fix skirmish entities to use Hellenic actors after removing the Athenian duplicates.
This was SVN commit r18367.
2016-06-12 15:13:09 +00:00
elexis 9dc66a27d8 Pass pointer by ref.
This was SVN commit r18366.
2016-06-12 14:37:13 +00:00
elexis 6e2106edd8 Fix whitespace, refs #3000.
This was SVN commit r18365.
2016-06-12 13:54:00 +00:00
elexis 38c7d7224a Elephants are not expected to capture buildings.
This was SVN commit r18363.
2016-06-11 16:07:28 +00:00
elexis a0960f4f89 Show the player color and name of units from other players garrisoned in allied buildings. Fixes #4052.
This was SVN commit r18362.
2016-06-11 15:02:34 +00:00