wraitii dcf5bad7fd Unit motion - Check the return value of ComputeGoal and handle failure cases ...

As reported by @Freagarach on #5496, there can be broken behaviour as
UnitMotion::PathResult may call RequestLongPath with an uninitialised
path goal when ComputeGoal fails.

To fix this, check the return value everywhere and react accordingly in
case of failure.

Fixes #5496

Differential Revision: https://code.wildfiregames.com/D2063
This was SVN commit r22458.

2019-07-12 16:16:13 +00:00

..

tests

Move "IsInRange" family of functions to the Obstruction Manager and make the commutative.

2019-06-06 19:37:23 +00:00

CCmpAIManager.cpp

Decouple long and hierarchical pathfinders to an extent.

2019-05-13 16:58:00 +00:00

CCmpCinemaManager.cpp

Draw paths only when cinematics isn't playing. Patch by Vladislav.

2017-05-08 04:02:33 +00:00

CCmpCommandQueue.cpp

More ScriptInterface const.

2017-11-25 06:49:58 +00:00

CCmpDecay.cpp

…

CCmpFootprint.cpp

Increase MaxSpawnDistance for ships

2018-03-02 18:10:54 +00:00

CCmpMinimap.cpp

Update the minimap, range overlay renderer, and status bars when a player's color is changed in Atlas.

2019-06-26 19:16:57 +00:00

CCmpMotionBall.cpp

…

CCmpObstruction.cpp

Unit Motion - make sure units that die while moving don't keep their obstruction

2019-07-10 18:43:21 +00:00

CCmpObstructionManager.cpp

UnitMotion - rename CheckTargetMovement to PathingUpdateNeeded for clarity, and improve the logic.

2019-07-03 18:06:53 +00:00

CCmpOverlayRenderer.cpp

Fix documentation of non system component.

2017-03-24 07:09:28 +00:00

CCmpOwnership.cpp

Bump year number of files changed this year in the license headers.

2017-05-01 14:28:22 +00:00

CCmpParticleManager.cpp

…

CCmpPathfinder_Common.h

Remove 'Async' from short/long path requests names

2019-05-26 13:47:41 +00:00

CCmpPathfinder.cpp

Remove 'Async' from short/long path requests names

2019-05-26 13:47:41 +00:00

CCmpPosition.cpp

Fix rotation of promoted turrets and allow fixing the turret angle in the GarrisonHolder schema.

2018-04-03 17:13:24 +00:00

CCmpProjectileManager.cpp

Fix some gcc 8 and gcc 9 compiler warnings that were thrown 4500 times.

2019-07-09 00:18:48 +00:00

CCmpRallyPointRenderer.cpp

Properly reset rally points on ownership changes.

2019-01-03 19:32:45 +00:00

CCmpRangeManager.cpp

Revert b56f7f39d4 as it triggers an assertion failure.

2019-01-05 22:38:00 +00:00

CCmpRangeOverlayRenderer.cpp

Update the minimap, range overlay renderer, and status bars when a player's color is changed in Atlas.

2019-06-26 19:16:57 +00:00

CCmpSelectable.cpp

Fix selection rings while garrisoning

2018-02-17 16:56:12 +00:00

CCmpSoundManager.cpp

Fix units not being able to play sounds when walking and running

2018-02-24 18:13:03 +00:00

CCmpTemplateManager.cpp

AIManager: loads only the used templates when starting (or deserializing) a game

2017-11-24 19:13:28 +00:00

CCmpTerrain.cpp

Recompute water graphics when changing the water level and upon deserialization to fix a graphical (non-simulation) OOS on rejoin.

2017-07-01 04:15:49 +00:00

CCmpTerritoryInfluence.cpp

…

CCmpTerritoryManager.cpp

Diplomacy Colors

2018-02-03 14:17:31 +00:00

CCmpTest.cpp

Bump year number of files changed this year in the license headers.

2017-05-01 14:28:22 +00:00

CCmpUnitMotion.cpp

Unit motion - Check the return value of ComputeGoal and handle failure cases

2019-07-12 16:16:13 +00:00

CCmpUnitRenderer.cpp

Cleanups BoundingBoxAxisAligned and fixes coding styles a bit.

2019-06-12 20:23:14 +00:00

CCmpVision.cpp

…

CCmpVisualActor.cpp

UnitMotion / AI - remove the special 'move' animation, make UnitMotion inform the visual actor directly.

2019-07-09 19:56:28 +00:00

CCmpWaterManager.cpp

Recompute water graphics when changing the water level and upon deserialization to fix a graphical (non-simulation) OOS on rejoin.

2017-07-01 04:15:49 +00:00

ICmpAIInterface.cpp

…

ICmpAIInterface.h

…

ICmpAIManager.cpp

Initialize the AIManager AISeed immediately in C++ rather than too late and in JS.

2017-12-27 16:51:25 +00:00

ICmpAIManager.h

Choose AI behavior in gamesetup

2017-12-20 22:02:15 +00:00

ICmpCinemaManager.cpp

Cinema Path GUI hiding and silhouettes fixes.

2017-06-17 14:17:30 +00:00

ICmpCinemaManager.h

Draw paths only when cinematics isn't playing. Patch by Vladislav.

2017-05-08 04:02:33 +00:00

ICmpCommandQueue.cpp

…

ICmpCommandQueue.h

…

ICmpDecay.cpp

…

ICmpDecay.h

…

ICmpFogging.cpp

…

ICmpFogging.h

…

ICmpFootprint.cpp

…

ICmpFootprint.h

…

ICmpGuiInterface.cpp

…

ICmpGuiInterface.h

…

ICmpIdentity.cpp

…

ICmpIdentity.h

…

ICmpMinimap.cpp

Stop serializing minimap playercolors

2018-01-07 20:23:04 +00:00

ICmpMinimap.h

Stop serializing minimap playercolors

2018-01-07 20:23:04 +00:00

ICmpMirage.cpp

…

ICmpMirage.h

…

ICmpMotion.cpp

…

ICmpMotion.h

…

ICmpObstruction.cpp

Fix mirages (and any other entity that blocks something but not BlockConstruction) blocking foundation construction following 29492badb7 / D21.

2018-03-26 15:18:53 +00:00

ICmpObstruction.h

Fix mirages (and any other entity that blocks something but not BlockConstruction) blocking foundation construction following 29492badb7 / D21.

2018-03-26 15:18:53 +00:00

ICmpObstructionManager.cpp

Move "IsInRange" family of functions to the Obstruction Manager and make the commutative.

2019-06-06 19:37:23 +00:00

ICmpObstructionManager.h

UnitMotion - rename CheckTargetMovement to PathingUpdateNeeded for clarity, and improve the logic.

2019-07-03 18:06:53 +00:00

ICmpOverlayRenderer.cpp

…

ICmpOverlayRenderer.h

…

ICmpOwnership.cpp

…

ICmpOwnership.h

…

ICmpParticleManager.cpp

…

ICmpParticleManager.h

…

ICmpPathfinder.cpp

Fix the Mustang template. Add tests for the UnitMotionFlying component.

2017-04-03 09:58:01 +00:00

ICmpPathfinder.h

Remove 'Async' from short/long path requests names

2019-05-26 13:47:41 +00:00

ICmpPlayer.cpp

Split CColor from Shapes.

2019-01-13 15:38:41 +00:00

ICmpPlayer.h

Diplomacy Colors

2018-02-03 14:17:31 +00:00

ICmpPlayerManager.cpp

…

ICmpPlayerManager.h

…

ICmpPosition.cpp

Rename cmpPosition's IsFloating to CanFloat.

2017-09-18 09:54:54 +00:00

ICmpPosition.h

Rename cmpPosition's IsFloating to CanFloat.

2017-09-18 09:54:54 +00:00

ICmpProjectileManager.cpp

Let the template define the actor used for the projectile. Also let projectiles have an impact animation (such as an explosion).

2017-12-23 09:27:19 +00:00

ICmpProjectileManager.h

Let the template define the actor used for the projectile. Also let projectiles have an impact animation (such as an explosion).

2017-12-23 09:27:19 +00:00

ICmpRallyPoint.cpp

Spawn units in rally point direction

2018-02-07 20:58:07 +00:00

ICmpRallyPoint.h

Spawn units in rally point direction

2018-02-07 20:58:07 +00:00

ICmpRallyPointRenderer.cpp

Diplomacy Colors

2018-02-03 14:17:31 +00:00

ICmpRallyPointRenderer.h

Spawn units in rally point direction

2018-02-07 20:58:07 +00:00

ICmpRangeManager.cpp

Add GetGaiaAndNonGaiaEntities helper function in the RangeManager and use it in Extinct Volcano (D229).

2017-12-26 22:03:25 +00:00

ICmpRangeManager.h

Add GetGaiaAndNonGaiaEntities helper function in the RangeManager and use it in Extinct Volcano (D229).

2017-12-26 22:03:25 +00:00

ICmpRangeOverlayRenderer.cpp

Diplomacy Colors

2018-02-03 14:17:31 +00:00

ICmpRangeOverlayRenderer.h

Diplomacy Colors

2018-02-03 14:17:31 +00:00

ICmpSelectable.cpp

Split CColor from Shapes.

2019-01-13 15:38:41 +00:00

ICmpSelectable.h

Diplomacy Colors

2018-02-03 14:17:31 +00:00

ICmpSettlement.cpp

…

ICmpSettlement.h

…

ICmpSound.cpp

Fix units not being able to play sounds when walking and running

2018-02-24 18:13:03 +00:00

ICmpSound.h

Fix units not being able to play sounds when walking and running

2018-02-24 18:13:03 +00:00

ICmpSoundManager.cpp

Add a new function to emit a sound from a position not attached to an entity. Use it to improve the attack impact sound code and allow to emit that sound even if the attacker died meanwhile. Use the sound provided by Pureon for catapult. Fix #4779.

2017-09-28 19:26:07 +00:00

ICmpSoundManager.h

Add a new function to emit a sound from a position not attached to an entity. Use it to improve the attack impact sound code and allow to emit that sound even if the attacker died meanwhile. Use the sound provided by Pureon for catapult. Fix #4779.

2017-09-28 19:26:07 +00:00

ICmpTemplateManager.cpp

Switch back to an unplaceable filter for templates.

2017-09-30 15:22:51 +00:00

ICmpTemplateManager.h

AIManager: loads only the used templates when starting (or deserializing) a game

2017-11-24 19:13:28 +00:00

ICmpTerrain.cpp

Replace hardcoded copies of a C++ simulation constant in JS used to compute the mapsize with a call to a new getter in the C++ interface.

2017-05-31 16:43:57 +00:00

ICmpTerrain.h

Replace hardcoded copies of a C++ simulation constant in JS used to compute the mapsize with a call to a new getter in the C++ interface.

2017-05-31 16:43:57 +00:00

ICmpTerritoryDecayManager.cpp

Add a TerritoryDecayManager component to update territoryMap with the blinking state when territories are recomputed. That's needed by the AI which was up to now not aware of blinking cells.

2017-10-07 08:42:39 +00:00

ICmpTerritoryDecayManager.h

Add a TerritoryDecayManager component to update territoryMap with the blinking state when territories are recomputed. That's needed by the AI which was up to now not aware of blinking cells.

2017-10-07 08:42:39 +00:00

ICmpTerritoryInfluence.cpp

…

ICmpTerritoryInfluence.h

…

ICmpTerritoryManager.cpp

Diplomacy Colors

2018-02-03 14:17:31 +00:00

ICmpTerritoryManager.h

Diplomacy Colors

2018-02-03 14:17:31 +00:00

ICmpTest.cpp

…

ICmpTest.h

…

ICmpUnitMotion.cpp

Move "IsInRange" family of functions to the Obstruction Manager and make the commutative.

2019-06-06 19:37:23 +00:00

ICmpUnitMotion.h

Unit Motion - remove the m_Moving variable

2019-06-09 17:04:18 +00:00

ICmpUnitRenderer.cpp

…

ICmpUnitRenderer.h

…

ICmpUnknownScript.cpp

…

ICmpUnknownScript.h

…

ICmpValueModificationManager.cpp

…

ICmpValueModificationManager.h

…

ICmpVisibility.cpp

…

ICmpVisibility.h

…

ICmpVision.cpp

…

ICmpVision.h

…

ICmpVisual.cpp

UnitMotion / AI - remove the special 'move' animation, make UnitMotion inform the visual actor directly.

2019-07-09 19:56:28 +00:00

ICmpVisual.h

UnitMotion / AI - remove the special 'move' animation, make UnitMotion inform the visual actor directly.

2019-07-09 19:56:28 +00:00

ICmpWaterManager.cpp

…

ICmpWaterManager.h

…