mirror of
https://gitea.wildfiregames.com/0ad/0ad.git
synced 2026-07-16 17:54:57 +00:00
wraitii
2cc071f306
Following 3a839517ce, SparseGrid::Reset() replaces the value of m_Data
(a C-style dynamically sized array) with a new value-initialised array,
by using the new operator. Previous code simply did a memset.
This means that when m_Data was not null, it leaked memory as the
previous array was not deleted.
SparseGrid::Reset is called when destroying the sparse grid, and a
SparseGrid is used by the long pathfinder when computing JPS paths. As
that is called rather often, it resulted in a relatively serious memory
leak that could make very long games use several GB of memory.
This fixes the leak by using placement new, which re-uses the memory,
effectively doing the same as the previously existing memset.
Profiling by historic_bruno and elexis showed that performance from
value-initialising with placement new was at worst similar to memset,
and testing shows this was compiled in a memset call in several cases
anyways.
Reviewed By: elexis
Fixes #5522
Differential Revision: https://code.wildfiregames.com/D2121
This was SVN commit r22545.
0 A.D. Introductory Information ================================= 0 A.D. (pronounced "zero ey-dee") is a free, open-source, cross-platform real-time strategy game of ancient warfare. This is currently an incomplete, under-development version of the game. We're always interested in getting more people involved, to help bring the game towards completion and to share the interesting experience of developing a project of this scope. There are several ways to contact us and find more information: Web site: http://play0ad.com/ Forums: http://www.wildfiregames.com/forum/ Trac (development info, bug tracker): http://trac.wildfiregames.com/ IRC: #0ad on irc.quakenet.org --------------------------------------- Running precompiled binaries on Windows --------------------------------------- Open the "binaries\system" folder. To launch the game: Run pyrogenesis.exe To launch the map editor: Run Atlas.bat or "pyrogenesis.exe -editor" ----------------------------------- Compiling the game from source code ----------------------------------- The instructions for compiling the game on Windows, Linux and OS X are at http://trac.wildfiregames.com/wiki/BuildInstructions ------------------ Reporting problems ------------------ Bugs should be reported on Trac. For information on reporting problems and finding logs, see http://trac.wildfiregames.com/wiki/ReportingErrors