Commit Graph

17496 Commits

Author SHA1 Message Date
elexis b5ea27904d JS GUI cleanup.
Mark g_CivData as const and don't use optional arguments at loadCivData.
Translate the infinity symbol in the summary screen.

Refs D829
Reviewed By: s0600204
This was SVN commit r20043.
2017-08-26 18:53:37 +00:00
elexis c4cef0d289 Don't write two helper variables to g_CivInfo in the structure tree,
so that the object has the same content throughout the entire GUI and
can be marked read-only.

Refs D829
Reviewed by: s0600204
This was SVN commit r20042.
2017-08-26 17:57:11 +00:00
elexis 16b976fc35 Remove unneeded GetMucMessageCount from the XmppClient.
The affected function was imprecise, because it called a playerlist
update whenever a "chat" level message was received instead
of only updating the playerlist if it's actually influencing the
displayed playerlist.
When there is a chat message, lobby subject change or user-role change,
there is no need to update the list.

Differential Revision: https://code.wildfiregames.com/D671
Refs #3386, 8b437a0b1c
Reviewed By: fpre / ffffffff
This was SVN commit r20040.
2017-08-25 18:51:26 +00:00
mimo ce7e727ff0 petra: revisit the phasing up to be more mod-friendly
Differential Revision: https://code.wildfiregames.com/D654
This was SVN commit r20039.
2017-08-25 16:23:23 +00:00
mimo bcdfbd28f8 Change some occurrences of BroadcastMessage where an entity id is available to use PostMessage
Patch by echotangoecho

Reviewed By: O2 JS Simulation, mimo
Differential Revision: https://code.wildfiregames.com/D733
This was SVN commit r20038.
2017-08-25 16:06:29 +00:00
leper ce580f0de0 Always delete CMapReader. Patch by Sandarac. Fixes #4154.
This fixes an assertion failure in ScriptEngine that can occur when
closing
the game while in the loading screen.

Reviewed By: vladislavbelov, leper
Differential Revision: https://code.wildfiregames.com/D684
This was SVN commit r20035.
2017-08-25 00:37:48 +00:00
elexis 9680b7437e Close the options page with escape.
Refs D813
Patch By: fpre / ffffffff
This was SVN commit r20034.
2017-08-24 22:55:08 +00:00
mimo f0a0f6c4cd Remove unused TemplateDataWithoutLocalization
Reviewed By: elexis
Differential Revision: https://code.wildfiregames.com/D831
This was SVN commit r20033.
2017-08-24 21:03:53 +00:00
elexis f27efac053 Enhance lobby / XMPP timestamp parsing documentation.
Refs #3832, 9a5e1ddedb / D760, 6141c5c4fa / D514
Reviewed By: leper
This was SVN commit r20032.
2017-08-24 20:57:21 +00:00
mimo a89c32f36b Petra: Fix some cases that would cause territory expansion with Sandbox difficulty
Patch by Sandarac

Reviewed By: mimo
Differential Revision: https://code.wildfiregames.com/D764
This was SVN commit r20031.
2017-08-24 19:47:35 +00:00
Imarok 31bbb56b58 Remove some unneeded ternary and fix some style issues in gamesetup.
Reviewed by: elexis
Differential Revision: https://code.wildfiregames.com/D615
This was SVN commit r20030.
2017-08-24 10:40:51 +00:00
leper 9defd11440 Pass ScriptInterface as a const ref where possible.
Reviewed By: elexis
Differential Revision: https://code.wildfiregames.com/D739
This was SVN commit r20028.
2017-08-24 00:32:42 +00:00
leper 7970c3dc54 Pass a const reference, if someone wants to modify it they should use the global directly.
Reviewed By: vladislavbelov
Differential Revision: https://code.wildfiregames.com/D738
This was SVN commit r20027.
2017-08-23 23:52:32 +00:00
mimo 683e19a7ed cleaning of the list of useful templates in AIInterface
This was SVN commit r20026.
2017-08-23 17:40:51 +00:00
mimo a13a860890 AI stats modifications from techs and auras broken for templates
Tested by Grugnas

Differential Revision: https://code.wildfiregames.com/D811
This was SVN commit r20025.
2017-08-23 17:31:47 +00:00
elexis d0654b4d58 Fix two translation oversights in 8cfd494b88 / D505.
This was SVN commit r20024.
2017-08-23 13:13:23 +00:00
elexis a93d260643 Add help button to Atlas with a link to the Manual and bugtracker.
Differential Revision: https://code.wildfiregames.com/D794
Patch By: Vladislav
This was SVN commit r20021.
2017-08-21 23:32:29 +00:00
s0600204 993b6c1632 Fix foundation 6x6 and 8x8 actors.
Patch By: Stan
Differential Revision: https://code.wildfiregames.com/D651
This was SVN commit r20020.
2017-08-21 19:08:56 +00:00
elexis 1ddd24bb8c Remove unused Renderer function from 12e2428495.
Refs #2137
Reviewed By: Vladislav
This was SVN commit r20019.
2017-08-21 17:05:45 +00:00
elexis d4cb7a05d7 Tiny JS options page cleanup.
Use strict comparison only if it actually matters.
Some var/let changes, refs D510.
Some lineendings.

This was SVN commit r20018.
2017-08-21 14:40:27 +00:00
elexis f61dd9bfc8 Grammar improvement for the wonder victory message, as proposed by WhiteTreePaladin / brian in accordance with 661284a403.
This was SVN commit r20017.
2017-08-21 13:13:08 +00:00
fatherbushido ff90bb8490 Fix issues with civ and classes bonuses for splash damage. Even if those bonuses were in splash schema they was not taken into account. Update, fix, clean and complete unit tests for those logic. Reviewed by Mate-86.
Differential Revision: https://code.wildfiregames.com/D792
This was SVN commit r20015.
2017-08-21 06:52:37 +00:00
elexis 028ce1d9e9 Use different translation contexts for the "enter your password" string.
Differential Revision: https://code.wildfiregames.com/D770
Based on patch by: Vladislav
This was SVN commit r20013.
2017-08-21 02:00:37 +00:00
elexis b1e3664208 Fix 23d8bc11a5 bug that shows the "enter your password" label before the password field becomes visible.
Update the string as assumed by Imarok in D715.

Differential Revision: https://code.wildfiregames.com/D788
Discussed with Vladislav in D770

This was SVN commit r20012.
2017-08-21 01:55:24 +00:00
elexis 6f9bf55ac5 Change the shadow map quality without restarting the match.
Differential Revision: https://code.wildfiregames.com/D804
Refs #4351
Patch By: Vladislav
This was SVN commit r20011.
2017-08-21 01:10:56 +00:00
elexis 04f2209b50 Rename WaterUgly setting to WaterEffects in order to remove the invertedboolean workaround of the options page.
Differential Revision: https://code.wildfiregames.com/D815
Refs #3737
Tested By: Stan
This was SVN commit r20010.
2017-08-21 00:09:25 +00:00
mimo abbdd391b5 Simplify work in translation of tutorials by cutting long strings by paragraph
Reviewed By: elexis
Differential Revision: https://code.wildfiregames.com/D802
also includes https://code.wildfiregames.com/D755

This was SVN commit r20009.
2017-08-20 18:04:48 +00:00
elexis 7d1e8056c1 Delete unused, not too appealing Modern Gray button from 80663a6c8a.
Fix some whitespace.

Differential Revision: https://code.wildfiregames.com/D809
In agreement with mimo

This was SVN commit r20008.
2017-08-20 18:03:47 +00:00
fatherbushido 4bd81b2761 Use the aimed position instead of the current target position for spread calculation. Patch by temple.
Differential Revision: https://code.wildfiregames.com/D780
This was SVN commit r20007.
2017-08-20 15:46:54 +00:00
elexis fc2cfd7744 Invert arrow sprites for sortable columns and unify duplication in a new ModernSortedList style.
Differential Revision: https://code.wildfiregames.com/D789
Patch By: fpre / ffffffff
Reviewed By: Vladislav
This was SVN commit r20006.
2017-08-20 12:23:08 +00:00
elexis 39e77a8caa Support the Message of the Day and Announcements sent by the lobby administrator instead of throwing a JS warning.
Display a message box for these as proposed by scythetwirler. Add a
comment explaining the origin of messages without "from" property, so
that commits like 39fcd1d031 don't remove that check unknowingly.
Document that We intend to not support private messages between users,
refs #3865, P61.

Fixes #4688.
Document that we currently don't intend to support private messages
between users, refs #3865, P61.

This was SVN commit r20005.
2017-08-20 11:34:24 +00:00
elexis 73481f4cc4 Support numerical data in option dropdowns, as expected by the shadow map quality option.
Differential Revision: https://code.wildfiregames.com/D803
Refs #4351, D745.
Patch By: Vladislav
This was SVN commit r20003.
2017-08-19 19:43:26 +00:00
elexis f8d53d8f7b Move summary screen and credits page Tab button styles to the Modern theme.
Expect that future tab pages reuse these themes.
Fix the selected tab button style of the credits page.
The last line of the former ForegroundBox overwrote the previous three
lines, which made the button appear with white text on light-golden
background.
Delete now empty theme files for the time being.

Differential Revision: https://code.wildfiregames.com/D786
Approach agreed with: Vladislav, bb

This was SVN commit r20002.
2017-08-19 19:00:26 +00:00
elexis 8df36bace4 Shadow map quality option.
Differential Revision: https://code.wildfiregames.com/D745
Fixes #4351
Refs #743
Patch By: Vladislav
This was SVN commit r20001.
2017-08-19 12:46:05 +00:00
elexis 661284a403 Fix some string issues and reveal the name of the next release (Ken Wood).
Change the tense of the Capture The Relic message, as proposed by brian
(WhiteTreePaladin).
Consistently use title case for buttons.
Use more descriptive and concise option titles.
Remove two unused strings.

Fixes #4718
Refs
https://wildfiregames.com/forum/index.php?/topic/22745-all-relics-captured-message/
Refs
https://wildfiregames.com/forum/index.php?/topic/22461-alpha-23-name-suggestions/
Reviewed by: brian (WhiteTreePaladin), leper, GunChleoc.
Release name agreed with Itms on 2017-07-29 on irc.

This was SVN commit r20000.
2017-08-19 11:47:24 +00:00
fatherbushido be2f3b4d42 Cap the pack progress getter at 100% to avoid oversizing bars in the gui. Update the test who caught that bug. Reviewed by bb_.
Differential Revision: https://code.wildfiregames.com/D796
This was SVN commit r19999.
2017-08-19 11:31:20 +00:00
mimo 8a32deb5ca Fix tutorial stuck after building farm
Trac Tickets: #4696, #4697

Differential Revision: https://code.wildfiregames.com/D774
This was SVN commit r19998.
2017-08-19 09:38:52 +00:00
elexis ce7848522e Fix copy&paste typo in the BuildRestrictions introduced by 9e39d6b46c.
Fixes #4728
Refs #3081, D276
Patch By: Grugnas
This was SVN commit r19997.
2017-08-19 08:44:09 +00:00
fatherbushido 67a7a92b95 Fix the missing hp for gates: when a full health wall was upgraded to a gate, it lost 1 hp. Complete c312c35698. Ultimately, the copy-move of health should be handled by the Health component itself.
This was SVN commit r19996.
2017-08-19 07:43:24 +00:00
fatherbushido c312c35698 Fix the missing health bug when an unit is promoted. Promotion component should not do the job of the Health component. Patch by Grugnas.
Accepted by FeXoR.
Differential Revision: https://code.wildfiregames.com/D409
This was SVN commit r19995.
2017-08-19 07:36:21 +00:00
fatherbushido bb58e7cb45 Add outlines of unit test for Promote component. Catch the missing 1 hp bug for the promoted unit when moving health from the old entity to the new one.
Differential Revision: https://code.wildfiregames.com/D798
This was SVN commit r19994.
2017-08-19 07:32:51 +00:00
elexis f1490be16f Delete unused ugly Yellow button theme.
Its experimental use in b2ec4e0e2a two days before the alpha 16 release
was reverted in d70abd548a following "complaints by team members" (Yves
and scythetwirler on 2014-05-10).

This was SVN commit r19993.
2017-08-18 22:30:24 +00:00
elexis 0d06fd00ab Modern style cleanup.
Unify three textPanel style copies in a new ModernTextPanel theme,
following the Credits page in bcf2c75513 and the Splash Screen in
5ce5ef9286 and the Manual in 4b06ebd52d.

Remove the unused textcolor_selected and the (because of a source/gui
bug) defacto unused font property.
Rudimentary scrolling support for the Splash Screen.
Remove now empty files for the time being.

This was SVN commit r19992.
2017-08-18 19:33:05 +00:00
elexis 0c43deaae4 Modern style cleanup.
Rename ModernTabLabelText and ModernLeftTabLabelText following
dc2b2aeff4 and 5582409973,
because these common styles are not inherently recommended to be used by
Tab pages, nor do only Tab pages use it.
Remove the unused ModernRightTabLabelText introduced by 5582409973.

This was SVN commit r19991.
2017-08-18 18:37:39 +00:00
elexis f08ccf2a43 Remove unused ModernPanel style introduced by 5582409973 that duplicates some properties of the widely used ModernWindow.
This was SVN commit r19990.
2017-08-18 17:39:54 +00:00
elexis 0063aca6b5 Simplify Tab handling of the credits page.
Differential Revision: https://code.wildfiregames.com/D785
Reviewed By: Vladislav
This was SVN commit r19989.
2017-08-18 16:30:11 +00:00
bb 7e1646afd5 Fix the attack cursor when the target is outside FoW and restrictedClasses are specified in the attack component by miraging the restrictedClasses data.
refs: d5db047c9a
Differential Revision: https://code.wildfiregames.com/D750
Reviewed By: mimo
This was SVN commit r19987.
2017-08-16 17:59:58 +00:00
fatherbushido d35fdbd542 Add some tests for Attack component. Some cleanup. Reviewed by Mate-86.
Differential Revision: https://code.wildfiregames.com/D782
This was SVN commit r19985.
2017-08-14 15:57:56 +00:00
mimo 36464f7fa7 a few petra cleanup, mainly useless parentheses
This was SVN commit r19984.
2017-08-14 11:16:04 +00:00
mimo 48c2e789b0 AI:fix typo spotted by s0600204, fixes #4720
This was SVN commit r19981.
2017-08-12 18:09:48 +00:00