Revert cf6aaf37a4, causing false OOS in visual replays.

cf6aaf37a4 fixed #5546, but it seems to cause some rare OOS in visual
replays, as reported in #5909. The culprit is likely that hashes aren't
computed at quite the same moment and onDestroy changes things.

Reverting for now before A24.

Reported by: Angen
Refs #5546.
Fixes #5909

This was SVN commit r24764.
This commit is contained in:
wraitii
2021-01-22 17:13:12 +00:00
parent 3becf25fac
commit e76745b0b2
2 changed files with 4 additions and 4 deletions
@@ -57,10 +57,10 @@ void CReplayTurnManager::StoreFinalReplayTurn(u32 turn)
m_FinalTurn = turn;
}
void CReplayTurnManager::NotifyFinishedOwnCommands(u32 turn)
void CReplayTurnManager::NotifyFinishedUpdate(u32 turn)
{
CLocalTurnManager::NotifyFinishedOwnCommands(turn);
turn = turn - COMMAND_DELAY;
if (turn == 1 && m_FinalTurn == 0)
g_GUI->SendEventToAll(EventNameReplayFinished);
if (turn > m_FinalTurn)
return;
@@ -37,7 +37,7 @@ public:
void StoreFinalReplayTurn(u32 turn);
private:
void NotifyFinishedOwnCommands(u32 turn) override;
void NotifyFinishedUpdate(u32 turn) override;
void DoTurn(u32 turn);