forked from mirrors/0ad
elexis
24f97d9fd5
Fixes an occurring leak indicated by the reported clang unused variable
compiler warning, refs #5294, #5550,
by adding the missing glooxwrapper::Jingle::Session::Session destructor
.
Fix two leaks that would have occurred if the according code had been
used:
Delete unused glooxwrapper::Jingle::ICEUDP::ICEUDP instead of adding the
missing destructor.
Delete unused glooxwrapper::Jingle::Content::Content instead of adding
the missing destructor.
Explain why glooxwrapper::Client::registerStanzaExtension doesn't leak
the new StanzaExtensionWrapper.
Explain why glooxwrapper::Jingle::Session::sessionInitiate doesn't leak
the new gloox::Jingle::Content, nor the new gloox::Jingle::ICEUDP.
Explain why glooxwrapper::SessionManager::registerPlugins doesn't leak
the new gloox::Jingle::Content and new gloox::Jingle::ICEUDP.
Explain why glooxwrapper::SessionManager::createSession doesn't leak the
gloox::Jingle::Session.
I will not leak memory in the glooxwrapper.
I will not leak memory in the glooxwrapper.
I will not leak memory in the glooxwrapper.
Use references in the StunClient and glooxwrapper to anticipate any
confusion as to whose obligation it is to delete variables when they are
passed around across several files.
Use static_cast and reinterpret_cast instead of C-style casts in the
StunClient.
Differential Revision: https://code.wildfiregames.com/D2094
Refs D2093 for the reported leaks.
Reviewed By: Josh
Comments By: fcxSanya, Vladislav for D2094, and echotangoecho, leper in
61261d14fc
This was SVN commit r22678.
0 A.D. Introductory Information ================================= 0 A.D. (pronounced "zero ey-dee") is a free, open-source, cross-platform real-time strategy game of ancient warfare. This is currently an incomplete, under-development version of the game. We're always interested in getting more people involved, to help bring the game towards completion and to share the interesting experience of developing a project of this scope. There are several ways to contact us and find more information: Web site: http://play0ad.com/ Forums: http://www.wildfiregames.com/forum/ Trac (development info, bug tracker): http://trac.wildfiregames.com/ IRC: #0ad on irc.quakenet.org --------------------------------------- Running precompiled binaries on Windows --------------------------------------- Open the "binaries\system" folder. To launch the game: Run pyrogenesis.exe To launch the map editor: Run Atlas.bat or "pyrogenesis.exe -editor" ----------------------------------- Compiling the game from source code ----------------------------------- The instructions for compiling the game on Windows, Linux and OS X are at http://trac.wildfiregames.com/wiki/BuildInstructions ------------------ Reporting problems ------------------ Bugs should be reported on Trac. For information on reporting problems and finding logs, see http://trac.wildfiregames.com/wiki/ReportingErrors