Use early return when there is no message

(cherry picked from commit c32a747873) Signed-off-by: Itms <itms@wildfiregames.com>
2024-12-31 13:13:20 +01:00
parent da87b72e6a
commit a4d1aebb74
1 changed files with 9 additions and 7 deletions
@@ -515,13 +515,15 @@ Player.prototype.SetState = function(newState, message)
 	Engine.PostMessage(this.entity, won ? MT_PlayerWon : MT_PlayerDefeated,
 		{ "playerId": this.playerID });

-	if (message)
-		Engine.QueryInterface(SYSTEM_ENTITY, IID_GuiInterface).PushNotification({
-			"type": won ? "won" : "defeat",
-			"players": [this.playerID],
-			"allies": [this.playerID],
-			"message": message
-		});
+	if (!message)
+		return;
+
+	Engine.QueryInterface(SYSTEM_ENTITY, IID_GuiInterface).PushNotification({
+		"type": won ? "won" : "defeat",
+		"players": [this.playerID],
+		"allies": [this.playerID],
+		"message": message
+	});
 };

 Player.prototype.GetFormations = function()