elexis ca2390d70e JS lobby cleanup, fixes and lobby bot performance improvements: ...

Do not send a wasteful rating request if the same player is selected
again when someone joined the lobby, when changing the sorting order or
when clicking on the same user again
by moving the player-selection change test from updatePlayerList to
onPlayerListSelection.

That test should have been done here in 8f4daa9dd0 already and fixes
#3840 well enough.

This change also fixes an unintentional behavior of the code, where the
game the currently selected player is playing in would be selected if
someone else joined the lobby, even if a different game was selected
manually.
Furthermore it allows simplification of the code of 655ce95468 by
removing selectGameFromPlayername which did almost the same as
selectGameFromPlayername.

To still select the game the current player is playing in if the
selected player didn't change, subscribe to the (new) event that is
called when clicking on an item.

Differential Revision: https://code.wildfiregames.com/D688
Reviewed By: ffffffff (fpre)
This was SVN commit r19841.

2017-06-29 02:58:04 +00:00

..

config

Rename the late observer setting "no one" to "disabled".

2017-06-02 22:11:05 +00:00

l10n

…

mods

JS lobby cleanup, fixes and lobby bot performance improvements:

2017-06-29 02:58:04 +00:00

tests

…

tools

…