Fabio Pedretti 4dfdfc12b2 Fix: Prevent out-of-bounds memory access in CheckBuildingPlacement ...

In `CCmpPathfinder::CheckBuildingPlacement`, the boundary check for the
vertical grid dimension (`j > m_TerrainOnlyGrid->m_H`) allowed `j` to equal
`m_TerrainOnlyGrid->m_H`. Since grid indices are 0-based (valid row indices
range from `0` to `m_H - 1`), this boundary condition allowed the loop to
execute with an out-of-bounds row index, leading to an invalid memory
read (`m_TerrainOnlyGrid->get(i, j)`) and potential segfaults.

This patch changes the comparison operator to `j >= m_TerrainOnlyGrid->m_H`,
ensuring that spans extending to or past the grid height bound are properly
flagged as out-of-bounds.

2026-09-01 10:54:32 +02:00

..

tests

Prevent div by zero in GetMaxReachableParabolicHeight

2026-08-26 10:55:27 +02:00

CCmpAIManager.cpp

Fix the deserialization of game state for AIs

2026-07-02 21:50:32 +02:00

CCmpCinemaManager.cpp

Makes GameView returning reference on camera

2026-06-28 17:57:16 +02:00

CCmpCommandQueue.cpp

Move Script* classes to Script namespace

2026-06-20 17:43:00 +02:00

CCmpDecay.cpp

fix debug build by directly setting probability for the inverse binomial in Decay.cpp

2025-10-08 17:00:09 +02:00

CCmpFootprint.cpp

…

CCmpMinimap.cpp

Remove <type> from minimap schema and templates

2025-10-26 21:43:25 +01:00

CCmpMotionBall.cpp

…

CCmpObstruction.cpp

Fix: Correct control group iteration in ResolveFoundationCollisions

2026-08-16 13:30:42 +02:00

CCmpObstructionManager.cpp

…

CCmpOverlayRenderer.cpp

Move cutscene mode to renderer

2026-03-03 11:25:52 +01:00

CCmpOwnership.cpp

…

CCmpParticleManager.cpp

…

CCmpPathfinder_Common.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

CCmpPathfinder.cpp

Fix: Prevent out-of-bounds memory access in CheckBuildingPlacement

2026-09-01 10:54:32 +02:00

CCmpPosition.cpp

Replace M_PI with C++ numbers

2026-06-04 20:29:48 +02:00

CCmpProjectileManager.cpp

LosRevealAll -> LosRevealWholeMap

2026-03-03 11:25:52 +01:00

CCmpRallyPointRenderer.cpp

Fix some includes all over the place

2025-08-14 20:15:30 +02:00

CCmpRallyPointRenderer.h

Fix -Wunnecessary-virtual-specifier warnings

2025-11-11 21:35:01 +01:00

CCmpRangeManager.cpp

Prevent div by zero in GetMaxReachableParabolicHeight

2026-08-26 10:55:27 +02:00

CCmpRangeOverlayRenderer.cpp

…

CCmpSelectable.cpp

Move cutscene mode to renderer

2026-03-03 11:25:52 +01:00

CCmpSoundManager.cpp

Move Script* classes to Script namespace

2026-06-20 17:43:00 +02:00

CCmpTemplateManager.cpp

…

CCmpTerrain.cpp

…

CCmpTerritoryInfluence.cpp

…

CCmpTerritoryManager.cpp

Replace M_PI with C++ numbers

2026-06-04 20:29:48 +02:00

CCmpTest.cpp

…

CCmpUnitMotion_System.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

CCmpUnitMotion.h

Fix formation reshuffling after entity rename

2026-02-04 11:05:07 +01:00

CCmpUnitMotionManager.h

Fix some includes all over the place

2025-08-14 20:15:30 +02:00

CCmpUnitRenderer.cpp

…

CCmpVision.cpp

Fix -Wunnecessary-virtual-specifier warnings

2025-11-11 21:35:01 +01:00

CCmpVisualActor.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

CCmpWaterManager.cpp

…

ICmpAIInterface.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpAIInterface.h

…

ICmpAIManager.cpp

Move Script* classes to Script namespace

2026-06-20 17:43:00 +02:00

ICmpAIManager.h

Move Script* classes to Script namespace

2026-06-20 17:43:00 +02:00

ICmpAttack.cpp

…

ICmpAttack.h

…

ICmpCinemaManager.cpp

Revamp CinemaManager component

2026-03-03 11:25:52 +01:00

ICmpCinemaManager.h

Makes GameView returning reference on camera

2026-06-28 17:57:16 +02:00

ICmpCommandQueue.cpp

…

ICmpCommandQueue.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpDecay.cpp

…

ICmpDecay.h

…

ICmpFogging.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpFogging.h

…

ICmpFootprint.cpp

Move Script* classes to Script namespace

2026-06-20 17:43:00 +02:00

ICmpFootprint.h

…

ICmpGarrisonHolder.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpGarrisonHolder.h

…

ICmpGuiInterface.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpGuiInterface.h

…

ICmpIdentity.cpp

…

ICmpIdentity.h

…

ICmpMinimap.cpp

…

ICmpMinimap.h

…

ICmpMirage.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpMirage.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpMotion.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpMotion.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpObstruction.cpp

Prevent targeting unreachable turreted entities

2026-08-12 22:40:59 +02:00

ICmpObstruction.h

Prevent targeting unreachable turreted entities

2026-08-12 22:40:59 +02:00

ICmpObstructionManager.cpp

…

ICmpObstructionManager.h

…

ICmpOverlayRenderer.cpp

Move cutscene mode to renderer

2026-03-03 11:25:52 +01:00

ICmpOverlayRenderer.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpOwnership.cpp

…

ICmpOwnership.h

…

ICmpParticleManager.cpp

…

ICmpParticleManager.h

…

ICmpPathfinder.cpp

…

ICmpPathfinder.h

…

ICmpPlayer.cpp

Replace old GetState and SetState calls

2026-07-22 23:51:49 +02:00

ICmpPlayer.h

Replace old GetState and SetState calls

2026-07-22 23:51:49 +02:00

ICmpPlayerManager.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpPlayerManager.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpPosition.cpp

…

ICmpPosition.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpProjectileManager.cpp

…

ICmpProjectileManager.h

…

ICmpRallyPoint.cpp

Fix some includes all over the place

2025-08-13 19:38:21 +02:00

ICmpRallyPoint.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpRallyPointRenderer.cpp

…

ICmpRallyPointRenderer.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpRangeManager.cpp

Prevent targeting unreachable turreted entities

2026-08-12 22:40:59 +02:00

ICmpRangeManager.h

Enable attacks on foes visible through shared LOS

2026-08-12 22:40:59 +02:00

ICmpRangeOverlayRenderer.cpp

…

ICmpRangeOverlayRenderer.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpSelectable.cpp

…

ICmpSelectable.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpSettlement.cpp

Fix some includes all over the place

2025-08-13 19:38:21 +02:00

ICmpSettlement.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpSound.cpp

…

ICmpSound.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpSoundManager.cpp

…

ICmpSoundManager.h

…

ICmpTemplateManager.cpp

…

ICmpTemplateManager.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpTerrain.cpp

…

ICmpTerrain.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpTerritoryDecayManager.cpp

Fix some includes all over the place

2025-08-13 19:38:21 +02:00

ICmpTerritoryDecayManager.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpTerritoryInfluence.cpp

…

ICmpTerritoryInfluence.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpTerritoryManager.cpp

…

ICmpTerritoryManager.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpTest.cpp

…

ICmpTest.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpTurretHolder.cpp

…

ICmpTurretHolder.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpUnitMotion.cpp

Fix formation reshuffling after entity rename

2026-02-04 11:05:07 +01:00

ICmpUnitMotion.h

Fix formation reshuffling after entity rename

2026-02-04 11:05:07 +01:00

ICmpUnitMotionManager.cpp

…

ICmpUnitMotionManager.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpUnitRenderer.cpp

…

ICmpUnitRenderer.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpUnknownScript.cpp

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpUnknownScript.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpValueModificationManager.cpp

…

ICmpValueModificationManager.h

Fix includes in source/simulation2

2025-08-08 07:10:11 +02:00

ICmpVisibility.cpp

…

ICmpVisibility.h

…

ICmpVision.cpp

…

ICmpVision.h

…

ICmpVisual.cpp

…

ICmpVisual.h

Fix some includes all over the place

2025-08-13 19:38:21 +02:00

ICmpWaterManager.cpp

…

ICmpWaterManager.h

…