mirrors/0ad
1
0
Fork 2
mirror of https://gitea.wildfiregames.com/0ad/0ad.git synced 2026-09-21 20:06:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove Script::CreateArray

Browse Source 
It's better to construct a js-array from a `JS::RootedValueVector`.
Because it is more strongly typed and the index doesn't has to be
specified when appending an element.
Some usages are replaced with `JS::RootedValueArray`.

Fixes: #8702
This commit is contained in:
phosit
2026-02-02 18:24:57 +01:00
parent fe9c0f6c2f
commit df18e22277
14 changed files with 146 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/ps/SavedGame.cpp
+8 -8
View File
@@ -1,4 +1,4 @@
/* Copyright (C) 2025 Wildfire Games.
/* Copyright (C) 2026 Wildfire Games.
* This file is part of 0 A.D.
*
* 0 A.D. is free software: you can redistribute it and/or modify
@@ -279,8 +279,7 @@ JS::Value SavedGames::GetSavedGames(const ScriptInterface& scriptInterface)
PROFILE2("GetSavedGames");
ScriptRequest rq(scriptInterface);
JS::RootedValue games(rq.cx);
Script::CreateArray(rq, &games);
JS::RootedValueVector games{rq.cx};
Status err;
@@ -288,10 +287,10 @@ JS::Value SavedGames::GetSavedGames(const ScriptInterface& scriptInterface)
err = vfs::GetPathnames(g_VFS, "saves/", L"*.0adsave", pathnames);
WARN_IF_ERR(err);
for (size_t i = 0; i < pathnames.size(); ++i)
for (const VfsPath& pathname : pathnames)
{
OsPath realPath;
err = g_VFS->GetRealPath(pathnames[i], realPath);
err = g_VFS->GetRealPath(pathname, realPath);
if (err < 0)
{
DEBUG_WARN_ERR(err);
@@ -319,13 +318,14 @@ JS::Value SavedGames::GetSavedGames(const ScriptInterface& scriptInterface)
Script::CreateObject(
rq,
&game,
"id", pathnames[i].Basename(),
"id", pathname.Basename(),
"metadata", metadata);
Script::SetPropertyInt(rq, games, i, game);
if (!games.append(game))
throw std::runtime_error{"Append failed"};
}
return games;
return JS::ObjectValue(*JS::NewArrayObject(rq.cx, games));
}
bool SavedGames::DeleteSavedGame(const std::wstring& name)