From d5af8a97c1b16f33ffc2e83e4e92e54c4d02a7b0 Mon Sep 17 00:00:00 2001 From: Fabio Pedretti Date: Mon, 24 Aug 2026 09:46:32 +0200 Subject: [PATCH] Lobby: Remove dead if(true)/else in GuiPollNewMessages() This is dead since 6fbf036ae4e --- source/lobby/XmppClient.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/source/lobby/XmppClient.cpp b/source/lobby/XmppClient.cpp index 851a6165eb..d49fb2f37f 100644 --- a/source/lobby/XmppClient.cpp +++ b/source/lobby/XmppClient.cpp @@ -903,15 +903,10 @@ JS::Value XmppClient::GuiPollNewMessages(const Script::Interface& guiInterface) continue; JS::RootedValue historicMessage(rq.cx, Script::DeepCopy(rq, rootedMessage)); - if (true) - { - Script::SetProperty(rq, historicMessage, "historic", true); - Script::DeepFreezeObject(rq, historicMessage); - if (!m_Impl->m_HistoricGuiMessages.append(historicMessage)) - throw std::runtime_error{"Append failed"}; - } - else - LOGERROR("Could not clone historic lobby GUI message!"); + Script::SetProperty(rq, historicMessage, "historic", true); + Script::DeepFreezeObject(rq, historicMessage); + if (!m_Impl->m_HistoricGuiMessages.append(historicMessage)) + throw std::runtime_error{"Append failed"}; } m_Impl->m_GuiMessageQueue.clear();