From ccd7481e5cc92cdfc4167eb771081079fd615160 Mon Sep 17 00:00:00 2001 From: phosit Date: Thu, 24 Sep 2026 13:00:33 +0200 Subject: [PATCH] Use const char* to print OpenGL messages GCC warns about a stringop-overread. There is no need to convert it to an `std::string` and back. --- source/renderer/backend/gl/Device.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source/renderer/backend/gl/Device.cpp b/source/renderer/backend/gl/Device.cpp index d68107a38b..f27d1b6f2c 100644 --- a/source/renderer/backend/gl/Device.cpp +++ b/source/renderer/backend/gl/Device.cpp @@ -125,9 +125,9 @@ void GLAD_API_PTR OnDebugMessage( GLenum source, GLenum type, GLuint id, GLenum severity, GLsizei /*length*/, const GLchar* message, const void* /*user_param*/) { - std::string debugSource = "unknown"; - std::string debugType = "unknown"; - std::string debugSeverity = "unknown"; + const char* debugSource = "unknown"; + const char* debugType = "unknown"; + const char* debugSeverity = "unknown"; switch (source) { @@ -201,7 +201,7 @@ void GLAD_API_PTR OnDebugMessage( if (severity == GL_DEBUG_SEVERITY_NOTIFICATION) { debug_printf( - "OpenGL | %s: %s source: %s id %u: %s\n", debugSeverity.c_str(), debugType.c_str(), debugSource.c_str(), id, message); + "OpenGL | %s: %s source: %s id %u: %s\n", debugSeverity, debugType, debugSource, id, message); } else {