mirrors/0ad
1
0
Fork 2
mirror of https://gitea.wildfiregames.com/0ad/0ad.git synced 2026-06-23 12:48:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

# housekeeping

Browse Source 
replaced all (*) CStr / CStrW by-value params with const reference. hoo
boy.

please always perform this optimization (actually standard idiom) when
writing the code - it takes little work, tells the next guy that the
string won't be modified, and makes a large performance difference.

(* where possible.. a few require other changes and will follow later)

This was SVN commit r4151.
This commit is contained in:
janwas
2006-07-20 14:37:58 +00:00
parent 3baa2d04b5
commit c817566222
75 changed files with 1109 additions and 1112 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/scripting/SynchedJSObject.cpp
+5 -5
View File
@@ -11,16 +11,16 @@ CStrW ToNetString(const uint &val)
}
template <>
void SetFromNetString(uint &val, CStrW string)
void SetFromNetString(uint &val, const CStrW& string)
{
val=string.ToUInt();
}
template <>
CStrW ToNetString(const CStrW &data)
CStrW ToNetString(const CStrW& data)
{ return data; }
template <> void SetFromNetString(CStrW &data, CStrW string)
template <> void SetFromNetString(CStrW& data, const CStrW& string)
{ data=string; }
template <>
@@ -34,7 +34,7 @@ CStrW ToNetString(const SColour &data)
}
template <>
void SetFromNetString(SColour &data, CStrW wstring)
void SetFromNetString(SColour &data, const CStrW& wstring)
{
CParser &parser(CParserCache::Get("$value_$value_$value_$value"));
CParserLine line;
@@ -67,7 +67,7 @@ void CSynchedJSObjectBase::IterateSynchedProperties(IterateCB *cb, void *userdat
}
}
ISynchedJSProperty *CSynchedJSObjectBase::GetSynchedProperty(CStrW name)
ISynchedJSProperty *CSynchedJSObjectBase::GetSynchedProperty(const CStrW& name)
{
SynchedPropertyIterator prop=m_SynchedProperties.find(name);
if (prop != m_SynchedProperties.end())