mirrors/0ad
1
0
Fork 2
mirror of https://gitea.wildfiregames.com/0ad/0ad.git synced 2026-07-25 20:13:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

# housekeeping

Browse Source 
replaced all (*) CStr / CStrW by-value params with const reference. hoo
boy.

please always perform this optimization (actually standard idiom) when
writing the code - it takes little work, tells the next guy that the
string won't be modified, and makes a large performance difference.

(* where possible.. a few require other changes and will follow later)

This was SVN commit r4151.
This commit is contained in:
janwas
2006-07-20 14:37:58 +00:00
parent 3baa2d04b5
commit c817566222
75 changed files with 1109 additions and 1112 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/scripting/ScriptableObject.h
+2 -2
View File
@@ -40,7 +40,7 @@ public:
// Add a property (with immediate value)
virtual void AddProperty( const CStrW& PropertyName, jsval Value ) = 0;
virtual void AddProperty( const CStrW& PropertyName, CStrW Value ) = 0;
virtual void AddProperty( const CStrW& PropertyName, const CStrW& Value ) = 0;
inline IJSObject() {}
};
@@ -281,7 +281,7 @@ public:
CJSValProperty* newProp = new CJSValProperty( Value );
m_ScriptProperties[PropertyName] = newProp;
}
void AddProperty( const CStrW& PropertyName, CStrW Value )
void AddProperty( const CStrW& PropertyName, const CStrW& Value )
{
AddProperty( PropertyName, JSParseString( Value ) );
}