mirror of
https://gitea.wildfiregames.com/0ad/0ad.git
synced 2026-10-14 06:58:07 +00:00
# Updates to actor prop-switching system
Forced variant names to lowercase. Allowed empty prop model names to remove inherited props. Removed a little code duplication. Entity: Changed confusing (and probably incorrect) loop/STL logic, to use slightly more confusing syntax instead. This was SVN commit r3761.
This commit is contained in:
@@ -109,7 +109,11 @@ CObjectEntry* CObjectManager::FindObjectVariation(CObjectBase* base, const std::
|
||||
|
||||
CObjectEntry* obj = new CObjectEntry(0, base); // TODO: type ?
|
||||
|
||||
if (! obj->BuildVariation(selections))
|
||||
// TODO (for some efficiency): use the pre-calculated choices for this object,
|
||||
// which has already worked out what to do for props, instead of passing the
|
||||
// selections into BuildVariation and having it recalculate the props' choices.
|
||||
|
||||
if (! obj->BuildVariation(selections, choices))
|
||||
{
|
||||
DeleteObject(obj);
|
||||
return NULL;
|
||||
|
||||
Reference in New Issue
Block a user