From 7ecd1d2c349bc468304305e88a59b863487c30f1 Mon Sep 17 00:00:00 2001
From: elexis <elexis@wildfiregames.com>
Date: Fri, 27 Apr 2018 16:06:42 +0000
Subject: [PATCH] Clean some forward declarations.

Remove unused (wrong copy&paste) includes from 86fcf0de8c in
JSInterface_ModIo.*, initially hinted at by leper.
Remove a forward declaration in JSInterface_Console.h that should have
become an include with 4b1297b328, because CxPrivate must be declared
before its reference too.
Remove a forward declaration in JSInterface_Mod.h from 64bfa089af that
should have been the include added in af03c72f76 which in turn omitted
to remove this forward declaration.
Remove a forward declaration in Renderer.h that became unused with
1ddd24bb8c.

Differential Revision: https://code.wildfiregames.com/D1470
Reviewed By: Itms
This was SVN commit r21788.
---
 source/ps/scripting/JSInterface_Console.cpp | 5 +++--
 source/ps/scripting/JSInterface_Console.h   | 2 +-
 source/ps/scripting/JSInterface_Mod.h       | 2 --
 source/ps/scripting/JSInterface_ModIo.cpp   | 1 -
 source/ps/scripting/JSInterface_ModIo.h     | 3 ---
 source/renderer/Renderer.h                  | 1 -
 6 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/source/ps/scripting/JSInterface_Console.cpp b/source/ps/scripting/JSInterface_Console.cpp
index c9992ea65d..51ff2d73f3 100644
--- a/source/ps/scripting/JSInterface_Console.cpp
+++ b/source/ps/scripting/JSInterface_Console.cpp
@@ -1,4 +1,4 @@
-/* Copyright (C) 2017 Wildfire Games.
+/* Copyright (C) 2018 Wildfire Games.
  * This file is part of 0 A.D.
  *
  * 0 A.D. is free software: you can redistribute it and/or modify
@@ -17,11 +17,12 @@
 
 #include "precompiled.h"
 
-#include "scriptinterface/ScriptInterface.h"
 #include "JSInterface_Console.h"
+
 #include "ps/CConsole.h"
 #include "ps/CLogger.h"
 #include "ps/Profile.h"
+#include "scriptinterface/ScriptInterface.h"
 
 bool JSI_Console::CheckGlobalInitialized()
 {
diff --git a/source/ps/scripting/JSInterface_Console.h b/source/ps/scripting/JSInterface_Console.h
index 369484c2e5..075f85eee3 100644
--- a/source/ps/scripting/JSInterface_Console.h
+++ b/source/ps/scripting/JSInterface_Console.h
@@ -18,7 +18,7 @@
 #ifndef INCLUDED_JSI_CONSOLE
 #define INCLUDED_JSI_CONSOLE
 
-class ScriptInterface;
+#include "scriptinterface/ScriptInterface.h"
 
 namespace JSI_Console
 {
diff --git a/source/ps/scripting/JSInterface_Mod.h b/source/ps/scripting/JSInterface_Mod.h
index 1b05aded50..e3f6662b79 100644
--- a/source/ps/scripting/JSInterface_Mod.h
+++ b/source/ps/scripting/JSInterface_Mod.h
@@ -21,8 +21,6 @@
 #include "ps/CStr.h"
 #include "scriptinterface/ScriptInterface.h"
 
-class ScriptInterface;
-
 namespace JSI_Mod
 {
 	void RegisterScriptFunctions(const ScriptInterface& scriptInterface);
diff --git a/source/ps/scripting/JSInterface_ModIo.cpp b/source/ps/scripting/JSInterface_ModIo.cpp
index 5c108cc052..fc1419bee8 100644
--- a/source/ps/scripting/JSInterface_ModIo.cpp
+++ b/source/ps/scripting/JSInterface_ModIo.cpp
@@ -20,7 +20,6 @@
 #include "JSInterface_ModIo.h"
 
 #include "ps/CLogger.h"
-#include "ps/Mod.h"
 #include "ps/ModIo.h"
 
 void JSI_ModIo::StartGetGameId(ScriptInterface::CxPrivate* UNUSED(pCxPrivate))
diff --git a/source/ps/scripting/JSInterface_ModIo.h b/source/ps/scripting/JSInterface_ModIo.h
index 5319cf74e3..e44ae9aea7 100644
--- a/source/ps/scripting/JSInterface_ModIo.h
+++ b/source/ps/scripting/JSInterface_ModIo.h
@@ -18,11 +18,8 @@
 #ifndef INCLUDED_JSI_MODIO
 #define INCLUDED_JSI_MODIO
 
-#include "ps/CStr.h"
 #include "scriptinterface/ScriptInterface.h"
 
-class ScriptInterface;
-
 namespace JSI_ModIo
 {
 	void RegisterScriptFunctions(const ScriptInterface& scriptInterface);
diff --git a/source/renderer/Renderer.h b/source/renderer/Renderer.h
index 1d37390fd2..e6b9029764 100644
--- a/source/renderer/Renderer.h
+++ b/source/renderer/Renderer.h
@@ -47,7 +47,6 @@ class CSimulation2;
 class CTextureManager;
 class CTimeManager;
 class RenderPathVertexShader;
-class ScriptInterface;
 class ShadowMap;
 class SkyManager;
 class TerrainRenderer;