Mod and mod-mounting cleanup and improvements.

mirror of https://gitea.wildfiregames.com/0ad/0ad.git synced 2026-06-21 01:04:06 +00:00

- Non-visual replays now automatically try to load the replay mods. This
removes the annoyance that -mod=public usually had to be passed.
- MountMods is no longer called in InitVfs but later, making it possible
to load the game in one pass & simplifying things considerably.
- Explicitly ignore duplicates when loading mods
- Interface cleanup: failed mods and incompatible mods were redundant,
only incompatible mods is kept.
- Interface cleanup: `AreModsCompatible`becomes
`CheckForIncompatibleMods`, which becomes a private pure function,
simplifying the control flow somewhat.
- Interface cleanup: `CheckAndEnableMods` is just `EnableMods`, which
explicitly updates loaded & incompatible mods.
- `CacheEnabledModVersions` becomes private and is called on behalf of
the user, removing the need to be careful about updating that (fixes my
concern at 44ec2e324e)

Overall, the logic around mounting & enabled mods should be easier to
understand.

Differential Revision: https://code.wildfiregames.com/D3982
This was SVN commit r25474.

This commit is contained in:

wraitii

2021-05-20 14:36:42 +00:00

parent 1e297fe212

commit 3bcf360107

13 changed files with 204 additions and 199 deletions

									
										source/ps/VisualReplay.cpp
									
		+1
		
												View File
												
				@@ -28,6 +28,7 @@

				#include "ps/CLogger.h"

				#include "ps/Filesystem.h"

				#include "ps/Game.h"

				#include "ps/GameSetup/CmdLineArgs.h"

				#include "ps/GameSetup/Paths.h"

				#include "ps/Mod.h"

				#include "ps/Pyrogenesis.h"