From 3801a4dd475bda6ca306863c99ec7be2a187f97d Mon Sep 17 00:00:00 2001 From: wraitii Date: Sun, 2 May 2021 15:43:59 +0000 Subject: [PATCH] Allow implicit JS boolean -> string conversions. `false` becomes `"false"`, `true` becomes `"true"`. Differential Revision: https://code.wildfiregames.com/D3917 This was SVN commit r25358. --- source/scriptinterface/ScriptConversions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/scriptinterface/ScriptConversions.cpp b/source/scriptinterface/ScriptConversions.cpp index 3a2b3aed1b..ed310d5a73 100644 --- a/source/scriptinterface/ScriptConversions.cpp +++ b/source/scriptinterface/ScriptConversions.cpp @@ -92,7 +92,7 @@ template<> bool ScriptInterface::FromJSVal(const ScriptRequest& rq, JS::Han template<> bool ScriptInterface::FromJSVal(const ScriptRequest& rq, JS::HandleValue v, std::wstring& out) { - WARN_IF_NOT(v.isString() || v.isNumber(), v); // allow implicit number conversions + WARN_IF_NOT(v.isString() || v.isNumber() || v.isBoolean(), v); // allow implicit boolean/number conversions JS::RootedString str(rq.cx, JS::ToString(rq.cx, v)); if (!str) FAIL("Argument must be convertible to a string");