From 0dc50ea1cd49327d57ce19056cb6688af8afae5e Mon Sep 17 00:00:00 2001
From: Ykkrosh <philip@wildfiregames.com>
Date: Wed, 11 Aug 2010 10:54:08 +0000
Subject: [PATCH] Fix GUI errors on broken entities with no icons. Delete some
 bogus icon sheet references.

This was SVN commit r7905.
---
 .../mods/public/gui/session_new/selection_details.js | 12 ++++++++++--
 .../simulation/templates/template_structure.xml      |  1 -
 .../public/simulation/templates/template_unit.xml    |  1 -
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/binaries/data/mods/public/gui/session_new/selection_details.js b/binaries/data/mods/public/gui/session_new/selection_details.js
index 54cc3af166..b5ae69eb14 100644
--- a/binaries/data/mods/public/gui/session_new/selection_details.js
+++ b/binaries/data/mods/public/gui/session_new/selection_details.js
@@ -111,8 +111,16 @@ function displayGeneralInfo(playerState, entState, template)
 	}
 
 	// Icon
-	getGUIObjectByName("sdIconImage").sprite = template.icon_sheet;
-	getGUIObjectByName("sdIconImage").cell_id = template.icon_cell;
+	if (template.icon_sheet && typeof template.icon_cell != "undefined")
+	{
+		getGUIObjectByName("sdIconImage").sprite = template.icon_sheet;
+		getGUIObjectByName("sdIconImage").cell_id = template.icon_cell;
+	}
+	else
+	{
+		// TODO: we should require all entities to have icons, so this case never occurs
+		getGUIObjectByName("sdIconImage").sprite = "bkFillBlack";
+	}
 	getGUIObjectByName("sdIcon").tooltip = iconTooltip;
 	//getGUIObjectByName("sdIconOutline"); // Need to change color of icon outline with the playerColor
 
diff --git a/binaries/data/mods/public/simulation/templates/template_structure.xml b/binaries/data/mods/public/simulation/templates/template_structure.xml
index bba106b2ce..d8c79945f4 100644
--- a/binaries/data/mods/public/simulation/templates/template_structure.xml
+++ b/binaries/data/mods/public/simulation/templates/template_structure.xml
@@ -2,7 +2,6 @@
 <Entity parent="template_entity_full">
   <Identity>
     <GenericName>Structure</GenericName>
-    <IconSheet>PortraitSheet</IconSheet>
   </Identity>
   <BuildRestrictions>
     <PlacementType>standard</PlacementType>
diff --git a/binaries/data/mods/public/simulation/templates/template_unit.xml b/binaries/data/mods/public/simulation/templates/template_unit.xml
index 745335640b..64a09f91bf 100644
--- a/binaries/data/mods/public/simulation/templates/template_unit.xml
+++ b/binaries/data/mods/public/simulation/templates/template_unit.xml
@@ -2,7 +2,6 @@
 <Entity parent="template_entity_full">
   <Identity>
     <GenericName>Unit</GenericName>
-    <IconSheet>PortraitSheet</IconSheet>
   </Identity>
   <Minimap>
     <Type>unit</Type>