From 0322d039f6a67496955791bebccccee695ff8c12 Mon Sep 17 00:00:00 2001 From: Atrik Date: Sun, 13 Sep 2026 10:44:47 +0200 Subject: [PATCH] Fix player data not updating on diplomacy change f39e71cca0 moved the player data refresh after a diplomacy change into a diplomacy colors change handler, which only runs when diplomacy colors are enabled. With them disabled, the diplomacy dialog's stance buttons didn't reflect the new stances. Refresh the player data directly in the diplomacy notification handler, before the diplomacy colors are recomputed, and remove the now redundant diplomacy colors handler registration. --- binaries/data/mods/public/gui/session/messages.js | 1 + binaries/data/mods/public/gui/session/session.js | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/binaries/data/mods/public/gui/session/messages.js b/binaries/data/mods/public/gui/session/messages.js index 18f1fc85d1..8c0010a717 100644 --- a/binaries/data/mods/public/gui/session/messages.js +++ b/binaries/data/mods/public/gui/session/messages.js @@ -146,6 +146,7 @@ var g_NotificationsTypes = }, "diplomacy": function(notification, player) { + updatePlayerData(); g_DiplomacyColors.onDiplomacyChange(); addChatMessage({ diff --git a/binaries/data/mods/public/gui/session/session.js b/binaries/data/mods/public/gui/session/session.js index 468e36a847..746f5c2fec 100644 --- a/binaries/data/mods/public/gui/session/session.js +++ b/binaries/data/mods/public/gui/session/session.js @@ -358,7 +358,6 @@ async function init(initData, hotloadData) handler(); registerPlayersFinishedHandler(updatePlayerData); - g_DiplomacyColors.registerDiplomacyColorsChangeHandler(updatePlayerData); registerCeasefireEndedHandler(updatePlayerData); if (hotloadData)