elexis 040624acff Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25. ...

Avoids one or two dozen unoptimizable string copies and two CPos copies,
mostly in SetupText.

The reference return allows to mark values as const where the previous
one prevented that.
This also reveals unused variables where the previous code hid them.

Thus use unused variable "buffer_zone" in the otherwise unused (since
b1422137e5, refs 0f807c643a) CCheckBox::SetupText() from b5f6d19332 and
use the unused variable "scrollbar" in CInput GUIM_MOUSE_PRESS_LEFT from
4113aa0a36.

Refs unintentionally copied DrawCall cache due to GetSetting copying in
c19f3608a5, fixed in 8f4f8e240f.

Differential Revision: https://code.wildfiregames.com/D2215
This was SVN commit r22765.

2019-08-23 14:43:10 +00:00

..

scripting

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

tests

…

CButton.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CButton.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CChart.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CChart.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CCheckBox.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CCheckBox.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CDropDown.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CDropDown.h

Mark some GUI functions as const, including the boolean ones from d4d5187c9d.

2019-08-22 23:51:10 +00:00

CGUI.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CGUI.h

Use variadic template for RecurseObject from c2a71e41bf and move it from GUIutil to IGUIObject.

2019-08-21 13:22:25 +00:00

CGUIColor.cpp

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CGUIColor.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CGUIList.h

…

CGUIScrollBarVertical.cpp

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CGUIScrollBarVertical.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CGUISeries.h

…

CGUISprite.cpp

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CGUISprite.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CGUIString.cpp

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CGUIString.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CGUIText.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CGUIText.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CImage.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CImage.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CInput.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CInput.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CList.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CList.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

COList.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

COList.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CProgressBar.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CProgressBar.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CRadioButton.cpp

Use variadic template for RecurseObject from c2a71e41bf and move it from GUIutil to IGUIObject.

2019-08-21 13:22:25 +00:00

CRadioButton.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CSlider.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CSlider.h

Mark some GUI functions as const, including the boolean ones from d4d5187c9d.

2019-08-22 23:51:10 +00:00

CText.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CText.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

CTooltip.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

CTooltip.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

GUI.h

…

GUIbase.cpp

…

GUIbase.h

Use variadic template for RecurseObject from c2a71e41bf and move it from GUIutil to IGUIObject.

2019-08-21 13:22:25 +00:00

GUIManager.cpp

Mark some GUI functions as const, including the boolean ones from d4d5187c9d.

2019-08-22 23:51:10 +00:00

GUIManager.h

Mark some GUI functions as const, including the boolean ones from d4d5187c9d.

2019-08-22 23:51:10 +00:00

GUIMatrix.cpp

…

GUIMatrix.h

…

GUIRenderer.cpp

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

GUIRenderer.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

GUIStringConversions.cpp

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

GUITooltip.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

GUITooltip.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

GUItypes.h

…

GUIutil.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

GUIutil.h

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

IGUIButtonBehavior.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

IGUIButtonBehavior.h

Use variadic template for RecurseObject from c2a71e41bf and move it from GUIutil to IGUIObject.

2019-08-21 13:22:25 +00:00

IGUIObject.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

IGUIObject.h

Mark some GUI functions as const, including the boolean ones from d4d5187c9d.

2019-08-22 23:51:10 +00:00

IGUIScrollBar.cpp

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

IGUIScrollBar.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

IGUIScrollBarOwner.cpp

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

IGUIScrollBarOwner.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

IGUITextOwner.cpp

Replace copy-assigning GUI<T>::GetSetting from c2a71e41bf with the reference returning GetSetting from 3dfa23cd25.

2019-08-23 14:43:10 +00:00

IGUITextOwner.h

Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively.

2019-08-21 10:12:33 +00:00

MiniMap.cpp

Mark some GUI functions as const, including the boolean ones from d4d5187c9d.

2019-08-22 23:51:10 +00:00

MiniMap.h

Mark some GUI functions as const, including the boolean ones from d4d5187c9d.

2019-08-22 23:51:10 +00:00