1
0
forked from mirrors/0ad
Commit Graph

1268 Commits

Author SHA1 Message Date
fatherbushido f5eabf8ec8 Reverts e38665d7a6 (excepting the buildtime part of iberian and macedonian fortress templates) as #3818 must be fixed in a cleaner way. Fixes a typo. Refs #3818.
This was SVN commit r18632.
2016-08-25 10:44:19 +00:00
leper 2f12bae102 Deal ranged damage even if the attacker dies. Patch by LeanderH. Fixes #3610.
Create a Damage system component from the Damage helper object and parts
of
the Attack component. This fixes the issue by making ranged damage
independent
of the attacking entity.

While there fix the issue of damaging all nearby entities in case the
actual
target was not hit, instead of only a single one.

This was SVN commit r18625.
2016-08-22 01:00:57 +00:00
leper 7947351a08 Add regression test for damage being dealt if the attacker dies. Based on patch by LeanderH. Refs #3610.
This was SVN commit r18624.
2016-08-22 01:00:30 +00:00
fatherbushido 289916b4d2 Updates Identity classes and visible classes documentation. Cleans inconsistencies (identation, some classes were sometimes in Classes and other times in VisibleClasses, adds missing class for javelinist cavalry hero, removes Camel classes from traders and seleucid cavalry, removes unused and misleading Light, Medium, Heavy classes). Comments by Sanderd17, elexis and s0600204. Refs #4147
This was SVN commit r18616.
2016-08-21 09:03:00 +00:00
elexis 416049e4b4 Remove charge attack from the templates which isn't implemented nor designed yet. Patch by fatherbushido, fixes #4139.
Remove the unused "recharge" attack timer which was introduced in
b21e798243 but should have been removed with 4e5c5e2d8f.

This was SVN commit r18599.
2016-08-11 14:35:50 +00:00
elexis 7a0703872f Remove a wrong argument from e3b3261a62.
This was SVN commit r18597.
2016-08-11 13:20:31 +00:00
elexis e3b3261a62 Attack component tests, reviewed by sanderd17.
This was SVN commit r18583.
2016-08-05 18:44:00 +00:00
fatherbushido 7ce9e7675f Adds and updates documentation in /components/interfaces/ files. Reviewed by elexis. Fixes #4128
This was SVN commit r18581.
2016-08-03 12:04:49 +00:00
fatherbushido 335b55d49b Add tests to AuraManager component. Fixes #4123
This was SVN commit r18576.
2016-08-02 12:19:40 +00:00
sanderd17 8af205fd71 Fix building of fields + update tests to make sure this doesn't happen again. Refs #4121
This was SVN commit r18575.
2016-08-02 11:54:18 +00:00
elexis 105e1484fb The repair button is expected to work with construction sites.
This was SVN commit r18571.
2016-07-30 23:52:09 +00:00
sanderd17 09ab4fe9d3 Add tests to the Foundation component + fix some minor issues found by implementing the tests. Fixes #4121
This was SVN commit r18567.
2016-07-29 11:48:07 +00:00
elexis a3da37ffd3 Gaia control improvements.
Don't throw errors when finishing a gaia foundation.
Allow cheats for gaia.

This was SVN commit r18552.
2016-07-24 02:19:34 +00:00
elexis cf04bad4bc Ingame summary screen and allied resource / population tooltips for active players. Patch by Imarok, also reviewed by fatherbushido and discussed with mimo, fixes #3841.
Shows (only) the stats of the current player in the summary screen while
playing.
Also shows those of mutual allies too if the shared vision tech is
researched.
Display the resources and population counts of allies in the tooltips of
the top panel.
Use a sprintf for the pop / limit ratio and remove hardcoded resource
strings in the XML, refs #3934.

This was SVN commit r18533.
2016-07-20 01:22:07 +00:00
elexis 2feeda802d Show the garrisoned healrate in tooltips, revealing not necessarily intuitive rates for special buildings and ships.
This was SVN commit r18529.
2016-07-19 13:19:37 +00:00
Itms ced8ceed47 Properly handle wonder victory messages after a player has won.
Patch by Sandarac, reviewed by elexis, fixes #4010

This was SVN commit r18514.
2016-07-13 06:51:59 +00:00
Itms 3d7c6981ca Fix a too early return and a wrong negation in the attack component "cleanup" of a09c59e044 that broke RestrictedClasses, thus stopped violent animals from attacking. Remove an unneeded space. Slaughter two if-statements whose condition is never satisfied (due to GetAttackTypes never returning that item) introduced in 092206b12e and ef4a1e261c.
Patch by elexis

This was SVN commit r18506.
2016-07-11 17:25:19 +00:00
mimo 73d62fb903 make the ai use allied dropsites when shared, fixes #4085
This was SVN commit r18503.
2016-07-10 17:44:48 +00:00
fatherbushido e38665d7a6 Use decimals instead of integers to allow relative templates for resource costs, as proposed by sanderd17, fixes #3818. Use relative templates following 68f87cb556.
This was SVN commit r18500.
2016-07-08 15:33:50 +00:00
elexis 888a281552 Complete rename of 9d20881ef4.
This was SVN commit r18493.
2016-07-07 01:22:03 +00:00
elexis 275be69883 Fix missing this-reference in 9d20881ef4 and update gamesetup following a874b3c1c3.
This was SVN commit r18492.
2016-07-07 00:10:26 +00:00
mimo 05195d0692 apply leaveFoundation to enemies when under ceaseFire, fixes #3667, patch by Sandarac
This was SVN commit r18488.
2016-07-05 17:13:35 +00:00
elexis 4fc8dc517f Delete command improvements and bugfixes.
Allow deleting of miraged foundations.
Add component method to set units undeletable. Based on patch by bb,
refs #3102.
If the control-all-units cheat is active, delete sheep, mostly captured
buildings and undeletable units.
Merge duplicate delete checks in the GUI. Thereby take into account the
control-all-units cheat and undeletability in all places.
Disable the delete button if the entity can't be deleted.
Add a tooltip for undeletability.
Don't colorize whitespace.
Remove unneeded comments.

This was SVN commit r18487.
2016-07-05 01:17:07 +00:00
elexis d9fa069ee7 Fix session implementation of the splash tooltip of 22b72a362b and related cleanup.
Add comments to document that GetEntityState and GetTemplateDataHelper
need to use the same object structure.
Remove four unneeded conditionals that are always true from
GetTemplateDataHelper.
Inline 3 splash damage variables in the attack component.

This was SVN commit r18485.
2016-07-04 22:16:35 +00:00
elexis 437cc13b95 Make charge attack unavailable from the simulation.
The order change to GetAttackTypes in a09c59e044 revealed that it was
only the GUI not triggering the buggy code.
Eliminate for-each of UnitAI calling that function.

This was SVN commit r18481.
2016-07-03 20:41:03 +00:00
elexis d99c5ce064 Fix typo.
This was SVN commit r18479.
2016-07-03 11:25:59 +00:00
elexis 22b72a362b Splash damage tooltip.
This was SVN commit r18477.
2016-07-03 04:08:52 +00:00
elexis fe8b65b708 Show the actual walk speed in the ingame tooltip. Patch by fatherbushido.
This was SVN commit r18475.
2016-07-03 02:25:57 +00:00
elexis 2a3d380e75 Upgrade component cleanup, refs #2706.
Use the cheat multiplier for upgrading and un/packing.
Remove if-statements that are always true.
Remove unused undefined "time" item from array in the selection panel.
Pass that object directly instead of copying each property explicitly.
Various indentation fixes in the selection panel code.

This was SVN commit r18472.
2016-07-03 01:50:55 +00:00
elexis c24b6b582d Fix tests. Patch by fatherbushido, refs #2706.
Some simplifications and array functions.
Fix indentation, thanks pastebin.

This was SVN commit r18471.
2016-07-02 21:32:09 +00:00
wraitii f468ac936b Fix to the upgrade commit, including one by fatherbushido. Refs #2706
This was SVN commit r18470.
2016-07-02 16:05:56 +00:00
wraitii b2f4b0f494 Allow entities to upgrade into other entities.
This new components allows giving the upgrade a cost, required
technologies, and a required time.
Implement gates using this generic component.
Fixes #2706

This was SVN commit r18467.
2016-07-01 19:43:26 +00:00
elexis 1276b98965 Argh.
This was SVN commit r18466.
2016-07-01 15:18:09 +00:00
elexis a09c59e044 Attack component cleanup.
Use .filter(), .every() and .some() to simplify, Math.max/min instead of
if-statements, inline functions, add newlines and allow attack orders
while flying.

This was SVN commit r18465.
2016-07-01 15:05:09 +00:00
elexis 9d20881ef4 Update healer tooltips to also show up in the selection details with actual values from the simulation. Based on patch by fatherbushido, fixes #4026.
Also clean up the Health component.
Rename healer to heal (as that is the actual component name).
Remove the structure tree code to replace a proper Templates.js
implementation.

This was SVN commit r18464.
2016-07-01 13:32:34 +00:00
elexis 9f796068f8 Win and defeat cleanup, fixes #4013.
Add a new simulation message and chat notification for players who won.
Avoid duplicate playerstate messages in the sim and GUI by triggering
changes with a function instead of a message.
Reveal the map on defeat/win exclusively in the player component
(instead of having a silly GUI proxy and doing it also in the
EndGameManager sometimes).
Remove the skipAlliedVictory argument from the player component, since
that shouldn't contain references to the EndGameManager, refs #3970.

Show a proper message box on win/loss and add the hint for hosts
disconnecting other players.
Do defeat/win procedure in the GUI when such a message arrives, instead
of checking onTick for playerstate changes.
Thus don't show that confirmation again on every rejoin.
Don't show a pointless message box if IsAtlasRunning.

Explain that the session.js variable is needed to avoid an
order-of-execution bug.
Select "observer" item when rejoining as a defeated player.
Remove an unneeded call to updateTopPanel.

This was SVN commit r18441.
2016-06-26 04:40:50 +00:00
mimo 98f8541581 remove a useless leftover var
This was SVN commit r18434.
2016-06-24 18:03:19 +00:00
elexis d8e9642d09 Fix lineendings of all files in simulation/.
This was SVN commit r18433.
2016-06-24 12:39:22 +00:00
elexis 989df9cb3b Fix lineendings of JS simulation components.
This was SVN commit r18432.
2016-06-24 12:23:39 +00:00
elexis 23a9fa1e65 Trigger script cleanup.
Remove tons of trailing whitespace.
Format JSdoc comments properly.
Use alphabetical sorting in array.
let instead of var.
Eliminate deprecated for-each.

This was SVN commit r18412.
2016-06-20 15:59:14 +00:00
elexis f4b818bec4 Wonder mode cleanup.
Remove unused, seemingly unusable wonder duration multiplier, refs
#3234.
Replace wonderDuration of the EndGameManager with gameTypeSettings,
since the component should be agnostic about victory condition logic.
Remove an unused cmpEndGameManager.
Inline a variable, few newlines, let intsead of var.

This was SVN commit r18398.
2016-06-17 14:24:30 +00:00
elexis f60befe098 Capture statistics summary. Patch by maveric and Imarok, fixes #3216.
Also colorize the headings, use two lines per player and remove
duplication of an ugly regex hack.

This was SVN commit r18395.
2016-06-17 02:27:11 +00:00
elexis a214f83017 Trader cleanup.
Remove unused required goods.
Won't be used since setting the goods individually for every trader is
overkill.

This was SVN commit r18393.
2016-06-16 20:54:31 +00:00
sanderd17 450973a624 Clean up some code-style issues reported by leper
This was SVN commit r18390.
2016-06-16 14:51:12 +00:00
elexis 0ce02441ee Simulation cleanup
Use QueryPlayerIDInterface to remove duplication as suggested by leper.
Remove its duplicate GetPlayerComponent.
Add IsOwnedByHelper and IsOwnedByEntityHelper to remove duplicated ally
check functions.
Remove unused function GetPlayerFilter from 17c473f2f3.
Remove unused variables and access to undefined ones identified using
jshint.
Rename cmpPlayerMan.

This was SVN commit r18382.
2016-06-15 16:13:08 +00:00
elexis 949f22b67d Victory check cleanup.
Use let instead of var.
Add newlines and a missing semicolon.
Remove an excess semicolon.

This was SVN commit r18374.
2016-06-14 11:18:28 +00:00
elexis cd3c52c53f Last Man Standing mode. Based on patch by Sandarac, fixes #3970.
Also fix a simulation bug (check for allied victory on game start).
The mode is not a victory condition as it applies to all victoriy
conditions.

This was SVN commit r18342.
2016-06-08 11:03:16 +00:00
sanderd17 ffd1639f05 Implement damage variants with an example for the Iberian fire ship. Fixes #3983
This was SVN commit r18340.
2016-06-07 13:21:32 +00:00
mimo 04123e7725 some cleanup, reported by leper
This was SVN commit r18325.
2016-06-04 12:43:02 +00:00
elexis 6377670543 Simulation cleanup.
Fix previous commit and add missing semicolon.

This was SVN commit r18318.
2016-06-04 02:33:53 +00:00