gptbot/0ad
1
0
Fork 0
forked from mirrors/0ad
Code Pull Requests Activity

Enable ruff rules to check for ambiguous code

Browse Source 
This enables some ruff rules to check for ambiguous and dead Python
code, which might cause unintended side-effects.

The enabled rules are:

- a bunch of rules related to shadowing of builtin structures (A)
- a bunch of rules checking for unused arguments (ARG)
- a rule checking for useless expressions (B018)
- a rule checking for unbound loop variables (B023)
- a rule checking redefined function parameters (PLR1704)
This commit is contained in:
Dunedan
2024-08-27 19:28:11 +02:00
parent ee3318309b
commit ea647067f0
14 changed files with 55 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/tools/entity/checkrefs.py
+5 -6
View File
@@ -36,10 +36,9 @@ class CheckRefs:
self.supportedAnimationFormats = ("psa", "dae")
self.supportedAudioFormats = "ogg"
self.mods = []
self.__init_logger
self.__init_logger()
self.inError = False
@property
def __init_logger(self):
logger = getLogger(__name__)
logger.setLevel(INFO)
@@ -398,7 +397,7 @@ class CheckRefs:
reqTag = cmp_identity.find("Requirements")
if reqTag is not None:
def parse_requirements(req, recursionDepth=1):
def parse_requirements(fp, req, recursionDepth=1):
techsTag = req.find("Techs")
if techsTag is not None:
for techTag in techsTag.text.split():
@@ -410,12 +409,12 @@ class CheckRefs:
recursionDepth -= 1
allReqTag = req.find("All")
if allReqTag is not None:
parse_requirements(allReqTag, recursionDepth)
parse_requirements(fp, allReqTag, recursionDepth)
anyReqTag = req.find("Any")
if anyReqTag is not None:
parse_requirements(anyReqTag, recursionDepth)
parse_requirements(fp, anyReqTag, recursionDepth)
parse_requirements(reqTag)
parse_requirements(fp, reqTag)
cmp_researcher = entity.find("Researcher")
if cmp_researcher is not None: