gptbot/0ad
1
0
Fork 0
forked from mirrors/0ad
Code Pull Requests Activity

Stop running shrinking gcs & simplify GC logic.

Browse Source 
Shrinking GCs dump the JITted code, which leads to redundant recompilations, lowers performance, and makes profiling JS more difficult.
They may still happen if the runtime is at risk of OOM.
This commit is contained in:
Lancelot de Ferrière
2024-11-23 18:36:23 +01:00
committed by wraitii
parent d262eb8757
commit af32d386b9
8 changed files with 96 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/simulation2/Simulation2.cpp
+1 -12
View File
@@ -484,20 +484,9 @@ void CSimulation2Impl::Update(int turnLength, const std::vector<SimulationComman
}
}
// Run the GC occasionally
// No delay because a lot of garbage accumulates in one turn and in non-visual replays there are
// much more turns in the same time than in normal games.
// Every 500 turns we run a shrinking GC, which decommits unused memory and frees all JIT code.
// Based on testing, this seems to be a good compromise between memory usage and performance.
// Also check the comment about gcPreserveCode in the ScriptInterface code and this forum topic:
// http://www.wildfiregames.com/forum/index.php?showtopic=18466&p=300323
//
// (TODO: we ought to schedule this for a frame where we're not
// running the sim update, to spread the load)
if (m_TurnNumber % 500 == 0)
scriptInterface.GetContext().ShrinkingGC();
else
scriptInterface.GetContext().MaybeIncrementalGC(0.0f);
scriptInterface.GetContext().MaybeIncrementalGC();
if (m_EnableOOSLog)
DumpState();