From 8b1cec7038b74d0dcb93ddb0fd7c3b8cb0404648 Mon Sep 17 00:00:00 2001 From: Ykkrosh Date: Sat, 31 Jul 2004 11:29:28 +0000 Subject: [PATCH] Removed some mildly unpleasant usages of temporary objects This was SVN commit r852. --- source/gui/scripting/JSInterface_IGUIObject.cpp | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/source/gui/scripting/JSInterface_IGUIObject.cpp b/source/gui/scripting/JSInterface_IGUIObject.cpp index 626a7f47ea..2f77ec9aec 100755 --- a/source/gui/scripting/JSInterface_IGUIObject.cpp +++ b/source/gui/scripting/JSInterface_IGUIObject.cpp @@ -1,4 +1,4 @@ -// $Id: JSInterface_IGUIObject.cpp,v 1.8 2004/07/24 14:11:12 philip Exp $ +// $Id: JSInterface_IGUIObject.cpp,v 1.9 2004/07/31 11:29:28 philip Exp $ #include "precompiled.h" @@ -198,9 +198,20 @@ JSBool JSI_IGUIObject::setProperty(JSContext* cx, JSObject* obj, jsval id, jsval { case GUIST_CStr: + { + CStr value = JS_GetStringBytes(JS_ValueToString(cx, *vp)); + GUI::SetSetting(e, propName, value); + break; + } + case GUIST_CGUIString: - e->SetSetting(propName, JS_GetStringBytes(JS_ValueToString(cx, *vp)) ); - break; + { + CStr value = JS_GetStringBytes(JS_ValueToString(cx, *vp)); + CGUIString str; + str.SetValue(value); + GUI::SetSetting(e, propName, str); + break; + } case GUIST_int: {