1
0
forked from mirrors/0ad

Remove virtual inheritance from the codebase, refs 6b51d71c85, e21ebb37f5 e326ebae46.

Remove workaround in 3d07327837 / D2136, the pointer from IGUIObject to
IGUITextOwner that avoided the dynamic_cast.
Have the GUIObject implementing class take responsibility of calling the
virtual methods in the base classes.
Leaves the code in a clean state that can serve as an example for new
GUI object classes, such as D1346, refs #4683.

Differential Revision: https://code.wildfiregames.com/D2325
Comments By: Vladislav on IRC 2019-07-30, 2019-08-22, 2019-09-20-23
Tested on: clang 8.0.1, Jenkins

This was SVN commit r23020.
This commit is contained in:
elexis
2019-09-30 14:08:14 +00:00
parent 1679510bb8
commit 8190293f8b
31 changed files with 293 additions and 250 deletions
+8 -1
View File
@@ -27,7 +27,7 @@
CTooltip::CTooltip(CGUI& pGUI)
: IGUIObject(pGUI),
IGUITextOwner(pGUI),
IGUITextOwner(*static_cast<IGUIObject*>(this)),
m_BufferZone(),
m_Caption(),
m_Font(),
@@ -133,8 +133,15 @@ void CTooltip::SetupText()
SetSetting<CClientArea>("size", size, true);
}
void CTooltip::UpdateCachedSize()
{
IGUIObject::UpdateCachedSize();
IGUITextOwner::UpdateCachedSize();
}
void CTooltip::HandleMessage(SGUIMessage& Message)
{
IGUIObject::HandleMessage(Message);
IGUITextOwner::HandleMessage(Message);
}