gptbot/0ad
1
0
Fork 0
forked from mirrors/0ad
Code Pull Requests Activity

Unit Motion - make sure units that die while moving don't keep their obstruction

Browse Source 
Introduced by 70e22e2923. PositionChanged messages sent between
MT_Destroy handling in CmpObstruction and the actual destruction of the
component could re-recreate an obstruction, which would then live
forever in the obstruction manager.

This prevents that by de-activating the obstruction when it is
destroyed, so that further PositionChanged messages do nothing.

Differential Revision: https://code.wildfiregames.com/D2060
This was SVN commit r22451.
This commit is contained in:
wraitii
2019-07-10 18:43:21 +00:00
parent bbc2e84160
commit 54f7a09a54
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/simulation2/components/CCmpObstruction.cpp
+2
View File
@@ -363,6 +363,8 @@ public:
if (!cmpObstructionManager)
break; // error
// Deactivate the obstruction in case PositionChanged messages are sent after this.
m_Active = false;
cmpObstructionManager->RemoveShape(m_Tag);
m_Tag = tag_t();
if(m_Type == CLUSTER)