From 2fd624260fd67da44a59adb2a6cbd51409d152ab Mon Sep 17 00:00:00 2001 From: Vantha Date: Wed, 10 Sep 2025 11:00:02 +0200 Subject: [PATCH] Remove some invalid GetGUIObjectByName calls Their return values (undefined) were unused since 2cccd9825d, which is why they didn't break anything. But due to the latest GetGUIObjectByName API changes, they triggered some errors. They can be fully removed safely now. Fixes #8340 --- binaries/data/mods/public/gui/lobby/LobbyPage/GameDetails.js | 1 - binaries/data/mods/public/gui/lobby/LobbyPage/ProfilePanel.js | 1 - 2 files changed, 2 deletions(-) diff --git a/binaries/data/mods/public/gui/lobby/LobbyPage/GameDetails.js b/binaries/data/mods/public/gui/lobby/LobbyPage/GameDetails.js index abd6ba50ab..6eddc8799a 100644 --- a/binaries/data/mods/public/gui/lobby/LobbyPage/GameDetails.js +++ b/binaries/data/mods/public/gui/lobby/LobbyPage/GameDetails.js @@ -18,7 +18,6 @@ class GameDetails this.sgMapName = Engine.GetGUIObjectByName("sgMapName"); this.sgGame = Engine.GetGUIObjectByName("sgGame"); this.sgPlayersAndMods = Engine.GetGUIObjectByName("sgPlayersAndMods"); - this.sgMapSize = Engine.GetGUIObjectByName("sgMapSize"); this.sgMapPreview = Engine.GetGUIObjectByName("sgMapPreview"); this.sgMapDescription = Engine.GetGUIObjectByName("sgMapDescription"); diff --git a/binaries/data/mods/public/gui/lobby/LobbyPage/ProfilePanel.js b/binaries/data/mods/public/gui/lobby/LobbyPage/ProfilePanel.js index 25eedb8428..a3e30afbde 100644 --- a/binaries/data/mods/public/gui/lobby/LobbyPage/ProfilePanel.js +++ b/binaries/data/mods/public/gui/lobby/LobbyPage/ProfilePanel.js @@ -19,7 +19,6 @@ class ProfilePanel this.totalGamesText = Engine.GetGUIObjectByName("totalGamesText"); this.highestRatingText = Engine.GetGUIObjectByName("highestRatingText"); this.rankText = Engine.GetGUIObjectByName("rankText"); - this.fade = Engine.GetGUIObjectByName("fade"); this.playernameText = Engine.GetGUIObjectByName("playernameText"); this.profileArea = Engine.GetGUIObjectByName("profileArea");