From 2fc12e9fe985ccb222eade7a75b3a02933734609 Mon Sep 17 00:00:00 2001 From: Itms Date: Sat, 9 Aug 2025 15:53:50 +0200 Subject: [PATCH] Remove obsolete comment, closes #5128 The wish I expressed there was fulfilled in D3210 / 0406c4dfdee8f94e1347db8d525a7658cae54c0d --- source/ps/ModIo.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/source/ps/ModIo.cpp b/source/ps/ModIo.cpp index 5fe96a1bed..f372c6af4e 100644 --- a/source/ps/ModIo.cpp +++ b/source/ps/ModIo.cpp @@ -658,9 +658,6 @@ bool ModIo::ParseGameIdResponse(const ScriptInterface& scriptInterface, const st JS::RootedValue idProperty(rq.cx); ENSURE(JS_GetProperty(rq.cx, firstObj, "id", &idProperty)); - // Make sure the property is not set to something that could be converted to a bogus value - // TODO: We should be able to convert JS::Values to C++ variables in a way that actually - // fails when types do not match (see https://gitea.wildfiregames.com/0ad/0ad/issues/5128). if (!idProperty.isNumber()) FAIL("id property not a number.");