Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting.

gptbot/0ad

Remove PSERROR codes from SetSetting (let std::map throw an out_of_range
if a caller wants to Set a setting that doesn't exist without having
checked with SettingExists, equal to GetSetting from 92b6cdfeab).
That also simplifies std::function SetSettingWrap construct from
0a7d0ecdde to void IGUIObject::SettingChanged.
Don't trigger debug_warn or exceptions in GUITooltip::ShowTooltip if the
XML author specified wrong tooltip input, and dodge another
dynamic_cast.

Rename existing IGUIObject::SetSetting to
IGUIObject::SetSettingFromString and comment that it is purposed for
parsing XML files.
Remove SetSetting default value, so that authors are made aware
explicitly of the need to decide the function broadcasting a message,
refs d87057b1c0, 719f2d7967, ...
Change const bool& SkipMessage to const bool SendMessage, so that a
positive value relates to a positive action.
Clean AddSettings whitespace and integer types.

Differential Revision: https://code.wildfiregames.com/D2231
Tested on: gcc 9.1.0, clang 8.0.1, Jenkins
Comments By: Philip on IRC on 2010-07-24 on GUIUtil being ugly, in case
that one counts

This was SVN commit r22796.

This commit is contained in:

elexis

2019-08-28 11:21:11 +00:00

parent 36e2c1caf8

commit 1a49ccb294

19 changed files with 203 additions and 231 deletions

									
										source/gui/CButton.cpp
									
		+1
		-1
	
												View File
												
				@@ -27,7 +27,7 @@ CButton::CButton(CGUI& pGUI)

				{

					AddSetting<float>("buffer_zone");

					AddSetting<CGUIString>("caption");

					AddSetting<int>("cell_id");

					AddSetting<i32>("cell_id");

					AddSetting<CStrW>("font");

					AddSetting<CStrW>("sound_disabled");

					AddSetting<CStrW>("sound_enter");